Skip to content

Add periodic jobs for Alibaba Disk CSI driver tests #26954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Mar 17, 2022
Merged

Add periodic jobs for Alibaba Disk CSI driver tests #26954

openshift-merge-robot merged 2 commits into from
Mar 17, 2022

Conversation

@jsafrane
Copy link
Contributor

@jsafrane jsafrane commented Mar 14, 2022 •
edited
Loading

Every 24 hours, like the other CSI tests. Both 4.11 and 4.10.

When at it, rework Alibaba credential request processing to use cloud-credentials-operator directly without extracting it in shell code. Periodic jobs were not able to pull CCO image from some reason.

@openshift-ci openshift-ci bot requested review from stbenjam and vrutkovs March 14, 2022 11:25
@jsafrane jsafrane mentioned this pull request Mar 14, 2022
Closed
@jsafrane jsafrane force-pushed the alibaba-periodic branch 3 times, most recently from fd0c638 to e57a0fe Compare March 14, 2022 19:47
@kwoodson
Copy link
Contributor

kwoodson commented Mar 15, 2022

/test pj-rehearse

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2022
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 16, 2022

Alright, 4.10 jobs look OK-ish (still red, but at least installed the cluster), 4.11 is being fixed in openshift/installer#5682

@kwoodson
Copy link
Contributor

kwoodson commented Mar 16, 2022

@jsafrane Thanks for the updates!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2022
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 17, 2022 •
edited
Loading

/assign @dgoodwin
for approval of new informing jobs.
They fail in the same way as in #26509, BZs will follow to keep track of the failures.

@vrutkovs
Copy link
Contributor

vrutkovs commented Mar 17, 2022

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2022
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 17, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

jsafrane added 2 commits March 17, 2022 11:01
@jsafrane
Use CCO image directly for Alibaba steps
8d93a0f 
Use cloud-credential-operator image with injected /bin/oc to run ccoctl
instead of extracting ccoctl from an image.
@jsafrane
Add periodic jobs for Alibaba Disk CSI driver tests
e31222e 
Every 24 hours, like other CSI tests.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2022
@jsafrane
Copy link
Contributor Author

jsafrane commented Mar 17, 2022

Rebased and lost lgtm

@vrutkovs
Copy link
Contributor

vrutkovs commented Mar 17, 2022

/lgtm

Lets see if this works

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2022
bertinatto
bertinatto reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, kwoodson, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b0b993f into openshift:master Mar 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2022

@jsafrane: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master__nightly-4.10.yaml using file ci-operator/config/openshift/release/openshift-release-master__nightly-4.10.yaml
    • key openshift-release-master__nightly-4.11.yaml using file ci-operator/config/openshift/release/openshift-release-master__nightly-4.11.yaml
  • job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-periodics.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key ipi-conf-alibabacloud-cloud-creds-deprovision-commands.sh using file ci-operator/step-registry/ipi/conf/alibabacloud/cloud-creds-deprovision/ipi-conf-alibabacloud-cloud-creds-deprovision-commands.sh
    • key ipi-conf-alibabacloud-cloud-creds-deprovision-ref.yaml using file ci-operator/step-registry/ipi/conf/alibabacloud/cloud-creds-deprovision/ipi-conf-alibabacloud-cloud-creds-deprovision-ref.yaml
    • key ipi-conf-alibabacloud-cloud-creds-provision-commands.sh using file ci-operator/step-registry/ipi/conf/alibabacloud/cloud-creds-provision/ipi-conf-alibabacloud-cloud-creds-provision-commands.sh
    • key ipi-conf-alibabacloud-cloud-creds-provision-ref.yaml using file ci-operator/step-registry/ipi/conf/alibabacloud/cloud-creds-provision/ipi-conf-alibabacloud-cloud-creds-provision-ref.yaml
Details

In response to this:

Every 24 hours, like the other CSI tests. Both 4.11 and 4.10.

When at it, rework Alibaba credential request processing to use cloud-credentials-operator directly without extracting it in shell code. Periodic jobs were not able to pull CCO image from some reason.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 17, 2022

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.10-e2e-aws-upgrade-rollback-oldest-supported b45dddefffba9ea0efad66ce60925a000f62e991 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.11-e2e-azure-fips b45dddefffba9ea0efad66ce60925a000f62e991 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-ipi-upgrade-ovn-ipv6 e57a0fecdd2a0157f622c78d6fdfea802e8e4386 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-ipi-serial-compact 9f7f6494f07a92dd15123f03d3258aeac242f4b1 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.11-e2e-telco5g e57a0fecdd2a0157f622c78d6fdfea802e8e4386 link unknown /test pj-rehearse
ci/rehearse/openshift/installer/release-4.12/e2e-alibaba e57a0fecdd2a0157f622c78d6fdfea802e8e4386 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.10-e2e-azure-csi-migration 9f7f6494f07a92dd15123f03d3258aeac242f4b1 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.11-e2e-metal-ipi-ovn-dualstack 9f7f6494f07a92dd15123f03d3258aeac242f4b1 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.10-console-aws e31222e link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.10-e2e-aws-single-node-serial e31222e link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.11-e2e-alibaba-csi e31222e link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.10-e2e-alibaba e31222e link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.10-e2e-aws-proxy e31222e link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stbenjam stbenjam Awaiting requested review from stbenjam

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

1 more reviewer

@bertinatto bertinatto bertinatto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dgoodwin dgoodwin

@vrutkovs vrutkovs

@bertinatto bertinatto

@kwoodson kwoodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@jsafrane @kwoodson @vrutkovs @openshift-bot @bertinatto @dgoodwin @openshift-merge-robot