Skip to content

Add alibaba periodic and informing jobs. Fix providerid issue. #26509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 15, 2022
Merged

Add alibaba periodic and informing jobs. Fix providerid issue. #26509

openshift-merge-robot merged 1 commit into from
Mar 15, 2022

Conversation

@kwoodson
Copy link
Contributor

@kwoodson kwoodson commented Feb 23, 2022

Expanding Alibaba's CI to run a periodic as well as create an informing job.

This job also fixes a console gathering issue where a providerID is used instead of an instanceID.

@kwoodson kwoodson requested a review from rvanderp3 February 23, 2022 18:30
@kwoodson
Copy link
Contributor Author

kwoodson commented Feb 23, 2022

Will update make release-controllers

@kwoodson
Copy link
Contributor Author

kwoodson commented Feb 23, 2022 

�[36mINFO�[0m[2022-02-23T19:36:40Z] Running step e2e-alibaba-gather-alibabacloud-console. 
�[36mINFO�[0m[2022-02-23T19:37:20Z] Step e2e-alibaba-gather-alibabacloud-console succeeded after 40s. \

@kwoodson kwoodson force-pushed the periodic_alibaba branch 3 times, most recently from 45e0b0d to d3eeb7a Compare February 23, 2022 21:54
@rvanderp3
Copy link
Contributor

rvanderp3 commented Feb 23, 2022

/retest

@kwoodson kwoodson force-pushed the periodic_alibaba branch 8 times, most recently from e85c225 to 953bb83 Compare February 24, 2022 21:58
@rvanderp3
Copy link
Contributor

rvanderp3 commented Feb 25, 2022

It looks like the alibabacloud provider isn't defined in the e2e tests for 4.10. It appears to be present in origin. e2e tests for 4.11 appear to recognize alibabacloud.

@kwoodson
Copy link
Contributor Author

kwoodson commented Feb 25, 2022

@rvanderp3
Looks like a backport never happend for this:
https://github.com/openshift/origin/blob/master/cmd/openshift-tests/provider.go#L25-L26

@kwoodson
Copy link
Contributor Author

kwoodson commented Feb 25, 2022

Found the backport: openshift/origin#26821

@kwoodson
Copy link
Contributor Author

kwoodson commented Mar 2, 2022

/test pj-rehearse

@kwoodson
Copy link
Contributor Author

kwoodson commented Mar 3, 2022

@rvanderp3 Tests are running for 4.10 and 4.11. Mind reviewing?

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2022
@kwoodson
Copy link
Contributor Author

kwoodson commented Mar 14, 2022

/test release-controller-config

@kwoodson
Copy link
Contributor Author

kwoodson commented Mar 14, 2022

/test pj-rehearse

@kwoodson
Copy link
Contributor Author

kwoodson commented Mar 14, 2022

This is now working on 4.10

Writing JUnit report to /logs/artifacts/junit/junit_e2e_20220314-182903.xml

error: 10 fail, 1172 pass, 1691 skip (36m7s)

This fixes the alibaba console gather

�[36mINFO�[0m[2022-03-14T18:30:07Z] Step e2e-alibaba-gather-alibabacloud-console succeeded after 40s.

@rvanderp3
Copy link
Contributor

rvanderp3 commented Mar 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2022
@kwoodson
Copy link
Contributor Author

kwoodson commented Mar 14, 2022

@stbenjam @dgoodwin Would either of you have a minute to review this PR? I have been told that TRT needs to approve.

@kwoodson kwoodson requested review from dgoodwin and stbenjam March 14, 2022 19:19
@dgoodwin
Copy link
Contributor

dgoodwin commented Mar 15, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, kwoodson, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2022

@kwoodson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.11-e2e-alibaba 823fbb0 link unknown /test pj-rehearse
ci/prow/pj-rehearse 823fbb0 link false /test pj-rehearse
ci/rehearse/openshift/alibaba-disk-csi-driver-operator/release-4.12/e2e-alibabacloud-disk-csi 823fbb0 link unknown /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.10-e2e-alibaba 823fbb0 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 2580e1e into openshift:master Mar 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2022

@kwoodson: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master__nightly-4.10.yaml using file ci-operator/config/openshift/release/openshift-release-master__nightly-4.10.yaml
    • key openshift-release-master__nightly-4.11.yaml using file ci-operator/config/openshift/release/openshift-release-master__nightly-4.11.yaml
  • job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-periodics.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key gather-alibabacloud-console-commands.sh using file ci-operator/step-registry/gather/alibabacloud-console/gather-alibabacloud-console-commands.sh
    • key ipi-conf-alibabacloud-cloud-creds-provision-commands.sh using file ci-operator/step-registry/ipi/conf/alibabacloud/cloud-creds-provision/ipi-conf-alibabacloud-cloud-creds-provision-commands.sh
Details

In response to this:

Expanding Alibaba's CI to run a periodic as well as create an informing job.

This job also fixes a console gathering issue where a providerID is used instead of an instanceID.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane jsafrane mentioned this pull request Mar 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvanderp3 rvanderp3 Awaiting requested review from rvanderp3

@deads2k deads2k Awaiting requested review from deads2k

@DennisPeriquet DennisPeriquet Awaiting requested review from DennisPeriquet

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

@stbenjam stbenjam Awaiting requested review from stbenjam

Assignees

@dgoodwin dgoodwin

@rvanderp3 rvanderp3

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kwoodson @rvanderp3 @dgoodwin @openshift-merge-robot