Skip to content

release-controller: Add ocp-4.11-rhel85.repo#26193

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cgwalters:release-controller-rhel85
Feb 15, 2022
Merged

release-controller: Add ocp-4.11-rhel85.repo#26193
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cgwalters:release-controller-rhel85

Conversation

@cgwalters
Copy link
Copy Markdown
Member

For RHCOS, we must have the ability to choose (as a pull request)
which version of RHEL we use to build.

Basically, I want to make https://github.com/openshift/os the canonical
source for this.

In preparation for that, add a split off rhel85 repository.

I think we should also add a corresponding rhel86 version, but
that can come in a bit.

Copy link
Copy Markdown
Member

@miabbott miabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the test failure is fixed

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2022
@cgwalters cgwalters force-pushed the release-controller-rhel85 branch from 09869dc to 68c447e Compare February 11, 2022 14:03
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2022
@petr-muller
Copy link
Copy Markdown
Member

/lgtm
/hold
/cc @jupierce

@openshift-ci openshift-ci bot requested a review from jupierce February 11, 2022 14:21
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2022
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 11, 2022
@jupierce
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jupierce, miabbott, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Copy Markdown
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2022
@cgwalters
Copy link
Copy Markdown
Member Author

Hmm, do I need to rebase to get sync-rover-groups to pass?

For RHCOS, we must have the ability to choose (as a pull request)
which version of RHEL we use to build.

Basically, I want to make https://github.com/openshift/os the canonical
source for this.

In preparation for that, add a split off rhel85 repository.

I think we should also add a corresponding rhel86 version, but
that can come in a bit.
@cgwalters cgwalters force-pushed the release-controller-rhel85 branch from 68c447e to 913a0ab Compare February 15, 2022 15:26
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 15, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2022
@cgwalters
Copy link
Copy Markdown
Member Author

Trying a rebase 🏄

@miabbott
Copy link
Copy Markdown
Member

Hmm, do I need to rebase to get sync-rover-groups to pass?

That job is not required and shouldn't prevent merging.

Wonder if I can do the magic...

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 15, 2022

@cgwalters: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e3e811a into openshift:master Feb 15, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 15, 2022

@cgwalters: Updated the following 6 configmaps:

  • base-repos configmap in namespace ocp at cluster build03 using the following files:
    • key ocp-4.11-rhel85.repo using file core-services/release-controller/_repos/ocp-4.11-rhel85.repo
  • base-repos configmap in namespace ocp at cluster build04 using the following files:
    • key ocp-4.11-rhel85.repo using file core-services/release-controller/_repos/ocp-4.11-rhel85.repo
  • base-repos configmap in namespace ocp at cluster vsphere using the following files:
    • key ocp-4.11-rhel85.repo using file core-services/release-controller/_repos/ocp-4.11-rhel85.repo
  • base-repos configmap in namespace ocp at cluster app.ci using the following files:
    • key ocp-4.11-rhel85.repo using file core-services/release-controller/_repos/ocp-4.11-rhel85.repo
  • base-repos configmap in namespace ocp at cluster build01 using the following files:
    • key ocp-4.11-rhel85.repo using file core-services/release-controller/_repos/ocp-4.11-rhel85.repo
  • base-repos configmap in namespace ocp at cluster build02 using the following files:
    • key ocp-4.11-rhel85.repo using file core-services/release-controller/_repos/ocp-4.11-rhel85.repo
Details

In response to this:

For RHCOS, we must have the ability to choose (as a pull request)
which version of RHEL we use to build.

Basically, I want to make https://github.com/openshift/os the canonical
source for this.

In preparation for that, add a split off rhel85 repository.

I think we should also add a corresponding rhel86 version, but
that can come in a bit.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

miabbott added a commit to miabbott/os that referenced this pull request Feb 15, 2022
We want to test RHCOS using RHEL 8.5 until we can switch to using RHEL
8.6, so use the newly created 8.5 repo.

See: openshift/release#26193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants