Skip to content

buildextend-live: drop legacy embed headers#2455

Merged
bgilbert merged 1 commit intocoreos:mainfrom
bgilbert:embed-removal
Feb 20, 2022
Merged

buildextend-live: drop legacy embed headers#2455
bgilbert merged 1 commit intocoreos:mainfrom
bgilbert:embed-removal

Conversation

@bgilbert
Copy link
Copy Markdown
Contributor

@bgilbert bgilbert commented Sep 22, 2021

coreos-installer now knows how to locate ignition.img and kargs.json directly in the ISO 9660 filesystem, so we don't need the custom coreiso+ and coreKarg headers anymore.

Requires coreos/coreos-installer#622 to land in a coreos-installer release and ship in Fedora CoreOS for a reasonable period of time.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Sep 22, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@bgilbert
Copy link
Copy Markdown
Contributor Author

/retest

@bgilbert
Copy link
Copy Markdown
Contributor Author

We should add a new coreos-installer test fixture once this lands.

@bgilbert
Copy link
Copy Markdown
Contributor Author

/test all

@bgilbert
Copy link
Copy Markdown
Contributor Author

/retest

@dustymabe
Copy link
Copy Markdown
Member

     --- FAIL: non-exclusive-test-bucket-0/ext.config.shared.networking.default-network-behavior-change (1.82s)
            harness.go:959: kolet failed: : kolet run-test-unit failed: Error: Unit kola-runext-38.service exited with code 1 

Should be fixed by coreos/fedora-coreos-config#1511 when that filters down to RHCOS right?

@cgwalters
Copy link
Copy Markdown
Member

rhcos CI is broken until openshift/os#714 (comment) is done

@cgwalters
Copy link
Copy Markdown
Member

/override ci/prow/rhcos

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Feb 11, 2022

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/rhcos

Details

In response to this:

/override ci/prow/rhcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bgilbert
Copy link
Copy Markdown
Contributor Author

/retest

coreos-installer now knows how to locate ignition.img and kargs.json
directly in the ISO 9660 filesystem, so we don't need the custom coreiso+
and coreKarg headers anymore.
@bgilbert
Copy link
Copy Markdown
Contributor Author

/test all

@bgilbert
Copy link
Copy Markdown
Contributor Author

/retest

1 similar comment
@bgilbert
Copy link
Copy Markdown
Contributor Author

/retest

@bgilbert
Copy link
Copy Markdown
Contributor Author

openshift/os#714 and openshift/release#26193 both merged, but RHCOS CI is still failing.

@bgilbert
Copy link
Copy Markdown
Contributor Author

/retest

@bgilbert bgilbert marked this pull request as ready for review February 17, 2022 18:01
@bgilbert
Copy link
Copy Markdown
Contributor Author

Ready for review!

Copy link
Copy Markdown
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bgilbert
Copy link
Copy Markdown
Contributor Author

ext.config.shared.networking.default-network-behavior-change is still broken.

/override ci/prow/rhcos

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Feb 20, 2022

@bgilbert: Overrode contexts on behalf of bgilbert: ci/prow/rhcos

Details

In response to this:

ext.config.shared.networking.default-network-behavior-change is still broken.

/override ci/prow/rhcos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants