ci-operator/step-registry/baremetalds/devscripts/setup: Set OPENSHIFT_UPGRADE_RELEASE_IMAGE #25123
Conversation
…_UPGRADE_RELEASE_IMAGE This allows the setup scripts to mirror that release image to, which will make is easier to get the appropriate content into imageContentSources.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| - name: "release:latest" | ||
| env: OPENSHIFT_INSTALL_RELEASE_IMAGE | ||
| - name: "release:latest" | ||
| env: OPENSHIFT_UPGRADE_RELEASE_IMAGE |
There was a problem hiding this comment.
Any specific reason to define a new distinct var? I guess we could reuse
There was a problem hiding this comment.
I don't think OVERRIDE is all that appropriate here. I felt strongly enough to break from tradition with my new variable, but not strongly enough to try and update existing variables.
There was a problem hiding this comment.
I think this could be a problematic duplication, given that the upgrade workflow already defined the OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE var (note: this was taken from the standard openshift e2e test step, as in future we'd like to use it directly) to specify the target release for the upgrade.
On the dev-scripts side of course there will be more choice for the naming of the exported configuration variable
There was a problem hiding this comment.
One day I'll get those steps moved too by reviving #12959. I just haven't been able to track down approvers yet. Anyhow, having the scripts prefer one and fall back to another is pretty easy:
OPENSHIFT_UPGRADE_RELEASE_IMAGE="${OPENSHIFT_UPGRADE_RELEASE_IMAGE_OVERRIDE:-${OPENSHIFT_UPGRADE_RELEASE_IMAGE}}"
some_consumer "${OPENSHIFT_UPGRADE_RELEASE_IMAGE}"But also, this is not my step, so feel free to file alternative PRs with whatever handling makes the most sense to you; no need to just follow my preferences ;)
|
/uncc |
|
Issues in openshift/release go stale after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issue in openshift/release rot after 15d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues in openshift/release close after 15d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
This allows the setup scripts to mirror that release image to, which will make is easier to get the appropriate content into
imageContentSources.