-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix cluster profiles for CBO and release jobs #24784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derekhiggins is this ok (not very clear from this diff)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I switched one job(nightly-4.6, e2e-metal-ipi ) back to packet in
job in ci-operator/config/openshift/release/openshift-release-master__nightly-4.6.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Switch over assistet and sno jobs to the correct profile
8d72572 to
f344db9
Compare
|
@derekhiggins: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@lranjbar could you please check if the assisted jobs failure are expected (I'd say so, given that just the cluster profile changed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error is unrelated to the profile change but if it isn't too much trouble to update the base images while we are here:
base_images:
assisted-image-service:
name: ocm-2.5
namespace: edge-infrastructure
tag: assisted-image-service
assisted-installer:
name: ocm-2.5
namespace: edge-infrastructure
tag: assisted-installer
assisted-installer-agent:
name: ocm-2.5
namespace: edge-infrastructure
tag: assisted-installer-agent
assisted-installer-controller:
name: ocm-2.5
namespace: edge-infrastructure
tag: assisted-installer-controller
assisted-service:
name: ocm-2.5
namespace: edge-infrastructure
tag: assisted-service
assisted-test-infra:
name: ocm-2.5
namespace: edge-infrastructure
tag: assisted-test-infra
|
Otherwise 👍 since errors are not related to this change |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andfasano, derekhiggins The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking could you please have a look at these changes? Thanks |
|
I think we can close it, addressed by #25355 |
|
/close |
|
@derekhiggins: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@lranjbar: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Switch over assistet and sno jobs to the correct profile