Wait until the image registry URL is propagated before doing e2e #2269
Conversation
The OpenShift apiserver is being programmed by the image-registry operator to have a new config value, but the apiserver being restarted is unnecessarily disruptive during rolling restart today. Until graceful shutdown is added we need to wait to start e2e until it's ready.
openshift-ci-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@smarterclayton: Updated the following 2 configmaps:
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| until oc get is -n openshift php 2>/dev/null; do | ||
| sleep 10 | ||
| done | ||
| until [[ -n "$( oc get is -n openshift php --template '{{ .status.dockerImageRepository }}' 2>/dev/null )" ]]; do |
There was a problem hiding this comment.
Can you drop the earlier until oc get ... and just use this loop? If you need to eat an exit code, maybe:
until [[ -n "$( oc get is -n openshift php --template '{{ .status.dockerImageRepository }}' 2>/dev/null || true)" ]]; doOn the other hand, this code will hopefully not live long, so no need to spend lots of time polishing ;).
4 participants
The OpenShift apiserver is being programmed by the image-registry operator
to have a new config value, but the apiserver being restarted is unnecessarily
disruptive during rolling restart today. Until graceful shutdown is added we
need to wait to start e2e until it's ready.