fixup/update installer-libvirt template

[sallyom]

This PR:

• updates cluster-launch-installer-libvirt template
• updates test command

[wking]

Are we versioning @ironcladlou's repo? I don't see us bumping it here. Or maybe we don't need any changes there?

[sallyom]

@wking We are not versioning https://github.com/ironcladlou/openshift4-libvirt-gcp, images are built manually (today) and pushed to gcp projects openshift-gce-devel-ci/openshift-devel-ci. The script to setup the libvirt environment in the gce image is updated according to changes in openshift/installer (by me, and we can discuss best way to maintain this in the future). We've discussed whether this setup should become an 'officially' supported development env, but last outcome of that was that this will be only maintained for CI purposes. The provisioning script is (pretty much) a mirror of the libvirt how-to docs, and could run with every CI job (rather than banked in a gce image) but that would increase the time of a libvirt test by a lot.

[wking]

Manually pushing is fine with me for now, I just wanted to make sure it was being bumped somehow ;).

[gbraad]

@praveenkumar @zeenix Might be of interest to you guys

[praveenkumar]

@wking @sallyom if that is ok can we merge this now?

[sallyom]

@wking, I have updated, been running with this, it's working well (the install times out but the setup is correct. The libvirt template creates an instance in gce, runs the install using the nested-libvirt setup, and the gce is deleted upon any hiccups or success).

This PR will give @praveenkumar and team a good starting point to get this job consistently passing (it's not run unless you comment in gh).

[wking]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sallyom, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/templates/openshift/installer/OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@sallyom: Updated the following 2 configmaps:

• prow-job-cluster-launch-installer-libvirt-e2e configmap in namespace ci using the following files:
  • key cluster-launch-installer-libvirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-libvirt-e2e.yaml
• prow-job-cluster-launch-installer-libvirt-e2e configmap in namespace ci-stg using the following files:
  • key cluster-launch-installer-libvirt-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-libvirt-e2e.yaml

Details

In response to this:

This PR:

• updates cluster-launch-installer-libvirt template
• updates test command

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.