[WIP] use env vars for OPENSHIFT_INSTALL vars for AWS, for local testing #2176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sallyom If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
/cc @wking |
sallyom
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
sallyom
force-pushed
the
env-vars-defaults-aws-installer
branch
2 times, most recently
from
00570ec to
aeb6dfb
Compare
openshift-ci-robot
added
size/XS
sallyom
force-pushed
the
env-vars-defaults-aws-installer
branch
from
aeb6dfb to
91c84ab
Compare
openshift-ci-robot
added
size/S
sallyom
force-pushed
the
env-vars-defaults-aws-installer
branch
from
91c84ab to
24f7a39
Compare
openshift-ci-robot
added
size/XS
sallyom
force-pushed
the
env-vars-defaults-aws-installer
branch
from
24f7a39 to
b79c86f
Compare
Contributor
Author
|
I don't think this is possible without adding an env var to every job. Setting the default in the template isn't possible, unless I'm missing something. I'm closing this for now, if there's a need for this I can re-open. |
gangwgr
added a commit
to gangwgr/release
that referenced
this pull request
Jan 6, 2026
Add cli-tests image build to enable testing of oc-tests-ext binary in CI rehearsals. Changes: - Add cli-tests image to images list with appropriate inputs - Exclude cli-tests from promotion (test-only image) This enables: - Building cli-tests image in CI from PR openshift#2176 - Testing oc-tests-ext integration with origin - Validating the extension framework before merge Related: - oc PR: openshift/oc#2176 - origin PR: https://github.com/gangwgr/origin/pull/new/test-oc-cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] while testing
This allows users to inject their own AWS installer vars to test ci-operator locally. The 2 templates that launch 4.0 clusters in AWS are updated here.
Only 1 other template references these 4.0 installer AWS vars, ci-operator/templates/openshift/openshift-ansible/cluster-launch-e2e-40.yaml, but AFAICT it's not functional yet, at least I wasn't able to launch in AWS via that template.