Skip to content

Conversation

@gangwgr
Copy link
Contributor

@gangwgr gangwgr commented Jan 6, 2026

Add cli-tests image build to enable testing of oc-tests-ext binary in CI rehearsals.

Changes:

  • Add cli-tests image to images list with appropriate inputs
  • Exclude cli-tests from promotion (test-only image)

Related:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2026
@gangwgr
Copy link
Contributor Author

gangwgr commented Jan 6, 2026

/test rehearse openshift/oc#2176 openshift/origin#30653

@openshift-ci openshift-ci bot requested review from atiratree and tchap January 6, 2026 05:36
@gangwgr
Copy link
Contributor Author

gangwgr commented Jan 6, 2026

/pj-rehearse openshift/oc#2176 openshift/origin#30653

@openshift-ci-robot
Copy link
Contributor

@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@gangwgr: job(s): openshift/oc#2176, openshift/origin#30653 either don't exist or were not found to be affected, and cannot be rehearsed

@gangwgr
Copy link
Contributor Author

gangwgr commented Jan 6, 2026

/test rehearse openshift/oc#2176 openshift/origin#30653

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 6, 2026

@gangwgr: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test app-ci-config-dry
/test boskos-config
/test boskos-config-generation
/test build01-dry
/test build02-dry
/test build03-dry
/test build04-dry
/test build06-dry
/test build07-dry
/test build08-dry
/test build09-dry
/test build10-dry
/test build11-dry
/test check-gh-automation
/test check-gh-automation-tide
/test ci-operator-config
/test ci-operator-config-metadata
/test ci-operator-registry
/test ci-secret-bootstrap-config-validation
/test ci-testgrid-allow-list
/test clusterimageset-validate
/test config
/test core-valid
/test generated-config
/test generated-dashboards
/test hosted-mgmt-dry
/test image-mirroring-config-validation
/test jira-lifecycle-config
/test labels
/test openshift-image-mirror-mappings
/test ordered-prow-config
/test owners
/test pr-reminder-config
/test prow-config
/test prow-config-filenames
/test prow-config-semantics
/test pylint
/test release-config
/test release-controller-config
/test rover-groups-config-validation
/test secret-generator-config-valid
/test services-valid
/test stackrox-stackrox-stackrox-stackrox-check
/test step-registry-metadata
/test step-registry-shellcheck
/test sync-rover-groups
/test verified-config
/test vsphere02-dry
/test yamllint

The following commands are available to trigger optional jobs:

/test build05-dry
/test check-cluster-profiles-config

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-release-check-gh-automation
pull-ci-openshift-release-master-ci-operator-config
pull-ci-openshift-release-master-ci-operator-config-metadata
pull-ci-openshift-release-master-ci-operator-registry
pull-ci-openshift-release-master-core-valid
pull-ci-openshift-release-master-generated-config
pull-ci-openshift-release-master-ordered-prow-config
pull-ci-openshift-release-master-owners
pull-ci-openshift-release-master-prow-config-filenames
pull-ci-openshift-release-master-release-controller-config
pull-ci-openshift-release-openshift-image-mirror-mappings
pull-ci-openshift-release-yamllint
Details

In response to this:

/test rehearse openshift/oc#2176 openshift/origin#30653

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gangwgr gangwgr force-pushed the rehearse-oc-tests-ext branch from 4ca86e6 to e4425b9 Compare January 6, 2026 13:57
@gangwgr gangwgr changed the title [WIP]Add cli-tests image to oc CI configuration Add cli-tests image to oc CI configuration Jan 6, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2026
@ardaguclu
Copy link
Member

/pj-rehearse pull-ci-openshift-oc-main-images

@openshift-ci-robot
Copy link
Contributor

@ardaguclu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@wangke19
Copy link
Contributor

wangke19 commented Jan 7, 2026

Missing Generated Artifacts, myabe make update is required.
Run make checkconfig to validate the configuration as well.

Add cli-tests image build to support oc-tests-ext test extension binary.

Changes:
- Add cli-tests image using cli as base (matches Dockerfile.rhel)
- Provide builder image input for build stage
- Exclude cli-tests from promotion (test-only image)

This enables:
- Building cli-tests image containing oc-tests-ext.gz
- Automatic extraction and execution of oc CLI extension tests
- Integration with OpenShift test framework via origin

The cli-tests image contains the oc-tests-ext binary (gzipped, ~24MB)
layered on top of the cli image, providing both oc and oc-tests-ext
for test execution.

Depends-On: openshift/oc#2176 (merged)
@gangwgr gangwgr force-pushed the rehearse-oc-tests-ext branch from e4425b9 to 650c051 Compare January 7, 2026 05:43
@gangwgr
Copy link
Contributor Author

gangwgr commented Jan 7, 2026

/pj-rehearse pull-ci-openshift-oc-main-images

@openshift-ci-robot
Copy link
Contributor

@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@gangwgr: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-oc-release-4.23-build-rpms-from-tar openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-e2e-agent-compact-ipv4 openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-e2e-agnostic-ovn-cmd openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-e2e-aws-certrotation openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-e2e-aws-ovn openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-e2e-aws-ovn-builds openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-e2e-aws-ovn-serial-1of2 openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-e2e-aws-ovn-serial-2of2 openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-e2e-aws-ovn-upgrade openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-e2e-metal-ipi-ovn-ipv6 openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-images openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-rpm-build openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-security openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-unit openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-verify openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.23-verify-deps openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.22-build-rpms-from-tar openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.22-e2e-agent-compact-ipv4 openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.22-e2e-agnostic-ovn-cmd openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.22-e2e-aws-certrotation openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.22-e2e-aws-ovn openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.22-e2e-aws-ovn-builds openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.22-e2e-aws-ovn-serial-1of2 openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.22-e2e-aws-ovn-serial-2of2 openshift/oc presubmit Ci-operator config changed
pull-ci-openshift-oc-release-4.22-e2e-aws-ovn-upgrade openshift/oc presubmit Ci-operator config changed

A total of 50 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@ardaguclu
Copy link
Member

/lgtm
/approve
/hold
until oc/main/images pass

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, gangwgr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2026
@gangwgr
Copy link
Contributor Author

gangwgr commented Jan 7, 2026

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 7, 2026
@gangwgr
Copy link
Contributor Author

gangwgr commented Jan 7, 2026

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@gangwgr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 7, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2026

@gangwgr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b73e4c4 into openshift:master Jan 7, 2026
14 checks passed
@gangwgr gangwgr changed the title Add cli-tests image to oc CI configuration CNTRLPLANE-2167:Add cli-tests image to oc CI configuration Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants