Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Oct 19, 2018

Make it easier for folks to figure out which version of the installer was used for a particular run.

CC @ironcladlou

Make it easier for folks to figure out which version of the installer
was used for a particular run.
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 19, 2018
@crawford
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 984b828 into openshift:master Oct 19, 2018
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the prow-job-cluster-launch-installer-e2e configmap using the following files:

  • key cluster-launch-installer-e2e.yaml using file ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
Details

In response to this:

Make it easier for folks to figure out which version of the installer was used for a particular run.

CC @ironcladlou

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the log-installer-version branch October 23, 2018 23:34
wking added a commit to wking/openshift-release that referenced this pull request Oct 26, 2018
Avoid:

  /bin/sh: line 5: /tmp/artifacts/installer/version: No such file or directory

in the container logs, fixing a bug from eba17a1
(cluster-launch-installer-e2e: Log the installer version,
2018-10-19, openshift#1981)
wking added a commit to wking/openshift-release that referenced this pull request Feb 26, 2019
I'd initially added this in eba17a1 (cluster-launch-installer-e2e:
Log the installer version, 2018-10-19, openshift#1981), but it's redundant
since openshift/installer@3d8019f9 (openshift-install: add version
string to logs, 2019-02-14, openshift/installer#1256).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants