-
Notifications
You must be signed in to change notification settings - Fork 1.5k
openshift-install: add version string to logs #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Including the version in the logs should make debugging a little easier since we'll definitively know which version of the installer produced them. This log entry was added under `setupFileHook()` since it felt natural to include it as part of the logfile setup: ensure the logging directory exists, ensure the logfile exists, append the current version.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
From the last error, I can see that we hit the rate limit when trying to create a route table association: <Response>
<Errors>
<Error>
<Code>RequestLimitExceeded</Code>
<Message>Request limit exceeded.</Message>
</Error>
</Errors>
<RequestID>c3ba9d60-4778-40bc-93cb-ef5ef0ed04e6</RequestID>
</Response>But the error reported by Terraform didn't seem to indicate that that was the root cause: Very interesting... |
|
e2e-aws was so close: /retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
I'd initially added this in eba17a1 (cluster-launch-installer-e2e: Log the installer version, 2018-10-19, openshift#1981), but it's redundant since openshift/installer@3d8019f9 (openshift-install: add version string to logs, 2019-02-14, openshift/installer#1256).
Including the version in the logs should make debugging a little easier
since we'll definitively know which version of the installer produced
them. This log entry was added under
setupFileHook()since it feltnatural to include it as part of the logfile setup: ensure the logging
directory exists, ensure the logfile exists, append the current version.