Skip to content

Conversation

@crawford
Copy link
Contributor

Including the version in the logs should make debugging a little easier
since we'll definitively know which version of the installer produced
them. This log entry was added under setupFileHook() since it felt
natural to include it as part of the logfile setup: ensure the logging
directory exists, ensure the logfile exists, append the current version.

Including the version in the logs should make debugging a little easier
since we'll definitively know which version of the installer produced
them. This log entry was added under `setupFileHook()` since it felt
natural to include it as part of the logfile setup: ensure the logging
directory exists, ensure the logfile exists, append the current version.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2019
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 14, 2019
@staebler
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@crawford
Copy link
Contributor Author

From the last error, I can see that we hit the rate limit when trying to create a route table association:

HTTP/1.1 503 Service Unavailable
<Response>
  <Errors>
    <Error>
      <Code>RequestLimitExceeded</Code>
      <Message>Request limit exceeded.</Message>
    </Error>
  </Errors>
  <RequestID>c3ba9d60-4778-40bc-93cb-ef5ef0ed04e6</RequestID>
</Response>

But the error reported by Terraform didn't seem to indicate that that was the root cause:

level=error msg="1 error occurred:"
level=error msg="\t* module.vpc.aws_route_table_association.private_routing[3]: 1 error occurred:"
level=error msg="\t* aws_route_table_association.private_routing.3: timeout while waiting for state to become 'success' (timeout: 5m0s)"

Very interesting...

@wking
Copy link
Member

wking commented Feb 15, 2019

e2e-aws was so close:

Failing tests:

[Conformance][Area:Networking][Feature:Router] The HAProxy router should enable openshift-monitoring to pull metrics [Suite:openshift/conformance/parallel/minimal]

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Feb 15, 2019

e2e-aws:

Flaky tests:

[Feature:DeploymentConfig] deploymentconfigs with test deployments [Conformance] should run a deployment to completion and then scale to zero [Suite:openshift/conformance/parallel/minimal]

Failing tests:

[Conformance][Area:Networking][Feature:Router] The HAProxy router should enable openshift-monitoring to pull metrics [Suite:openshift/conformance/parallel/minimal]

/retest

@openshift-merge-robot openshift-merge-robot merged commit e369eae into openshift:master Feb 15, 2019
@crawford crawford deleted the log-version branch February 15, 2019 19:00
wking added a commit to wking/openshift-release that referenced this pull request Feb 26, 2019
I'd initially added this in eba17a1 (cluster-launch-installer-e2e:
Log the installer version, 2018-10-19, openshift#1981), but it's redundant
since openshift/installer@3d8019f9 (openshift-install: add version
string to logs, 2019-02-14, openshift/installer#1256).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants