Update UPI CI jobs to use stream metadata, stop using pip #17482
Conversation
We should have python3 with pyyaml in the latest image.
cgwalters
force-pushed
the
gcp-upi-streams
branch
from
ce52f4c to
b9abed7
Compare
cgwalters
force-pushed
the
gcp-upi-streams
branch
from
b9abed7 to
2bc683f
Compare
This actually starts making use of the new rhel8 Dockerfile from: openshift/installer#4785 We need this to sanely use both python2 and python3 at the same time, which we need for gcloud (python2) and azure (python3).
We have the aws cli in our UPI container, and we're in a pip/python mess.
|
OK, this is now failing on
which is openshift/installer#4784 (comment) OK let's roll in #17110 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cgwalters The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cgwalters
changed the title
|
@cgwalters: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-rebase
|
/uncc |
In openshift/enhancements#679 we landed support for a stream metadata format already used by FCOS and now by RHCOS/OCP consumers to find the bootimages. We kept the old metadata because the UPI CI jobs used it. In openshift/release#17482 I tried to port the UPI CI jobs, but ran into huge levels of technical debt. As best I can tell, the UPI CI jobs are not running on this repo now and are likely broken for other reasons. Let's remove the old data and avoid the confusing duplication. Anyone who goes to work on the UPI CI jobs and sanitizes things should be able to pick up the work to port to stream metadata relatively easily.
In openshift/enhancements#679 we landed support for a stream metadata format already used by FCOS and now by RHCOS/OCP consumers to find the bootimages. We kept the old metadata because the UPI CI jobs used it. In openshift/release#17482 I tried to port the UPI CI jobs, but ran into huge levels of technical debt. As best I can tell, the UPI CI jobs are not running on this repo now and are likely broken for other reasons. Let's remove the old data and avoid the confusing duplication. Anyone who goes to work on the UPI CI jobs and sanitizes things should be able to pick up the work to port to stream metadata relatively easily.
|
I've pulled in part of this PR with #23392 |
|
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues in openshift/release go stale after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issue in openshift/release rot after 15d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues in openshift/release close after 15d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
step-registry/upi/gcp: Remove pip usage
We should have python3 with pyyaml in the latest image.
steps/gcp-upi: Use coreos print-stream-json if available
Part of openshift/enhancements#679
openshift/installer: Switch to rhel8 for UPI CI container
This actually starts making use of the new rhel8 Dockerfile from:
openshift/installer#4785
We need this to sanely use both python2 and python3 at the same time,
which we need for gcloud (python2) and azure (python3).
templates/installer: Stop using pip
We have the aws cli in our UPI container, and we're in a pip/python
mess.