images: Add Dockerfile.upi.ci.rhel8 #4785
Conversation
Fork the current rhel7 Dockerfile and port it to rhel8. This makes it easier to use both python2 and python3 at the same time, which we need for gcloud (python2) and azure (python3). We need to land this, then try changing CI to actually use it in a rehearsal job in openshift/release.
|
So the proposal here is to land this PR and then do a separate PR to openshift/release which switches to it (and starts ignoring the current Alternatively, we could try powering through this:
|
| openssl \ | ||
| python3-pyOpenSSL \ | ||
| python2-pyyaml \ | ||
| python3-pyyaml \ |
There was a problem hiding this comment.
Note we can easily get both python2+3 pyyaml now too; there's a lot of stuff in openshift/release still using python (aka python2).
staebler
left a comment
staebler
left a comment
There was a problem hiding this comment.
Long term I would like to separate out this image into smaller images that are built as supplemental CI images. But the changes in this PR seem reasonable as a short-term solution. Or I suppose even long-term we would still want to have the UPI image built on rhel8 rather than rhel7.
|
|
||
| # Not packaged for Python 2, but required by gcloud. See https://cloud.google.com/sdk/crypto | ||
| RUN pip-2 install pyopenssl | ||
| ENV CLOUDSDK_PYTHON=/usr/bin/python |
There was a problem hiding this comment.
This may not be needed any more.
|
Yeah, we could perhaps just do that now too - something like a new github.com/openshift/installer-upi-ci repo? Or just stick this Dockerfile inline into openshift/release ?
Definitely, no reason to drag rhel7 around longer. |
I was thinking about putting the images in https://github.com/openshift/release/tree/master/clusters/app.ci/supplemental-ci-images, which I just learned about today. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@cgwalters: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This actually starts making use of the new rhel8 Dockerfile from: openshift/installer#4785 We need this to sanely use both python2 and python3 at the same time, which we need for gcloud (python2) and azure (python3).
|
PR to use this in openshift/release#17110 |
This actually starts making use of the new rhel8 Dockerfile from: openshift/installer#4785 We need this to sanely use both python2 and python3 at the same time, which we need for gcloud (python2) and azure (python3).
5 participants
Fork the current rhel7 Dockerfile and port it to rhel8. This
makes it easier to use both python2 and python3 at the same time,
which we need for gcloud (python2) and azure (python3).
We need to land this, then try changing CI to actually use
it in a rehearsal job in openshift/release.