Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Sep 11, 2018

Catching up with 56600df (#1434) and ultimately with 199f2e0 (#1317).

/assign @smarterclayton

CC @sallyom

…onfig

Catching up with 56600df (add configmap for e2e-aws-smoke,
2018-09-10, openshift#1434) and ultimately with 199f2e0 (openshift/install
e2e-aws add run smoke tests, 2018-08-28, openshift#1317).
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2018
@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2018
@openshift-merge-robot openshift-merge-robot merged commit 2615673 into openshift:master Sep 11, 2018
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the plugins configmap using the following files:

  • key plugins.yaml using file cluster/ci/config/prow/plugins.yaml
Details

In response to this:

Catching up with 56600df (#1434) and ultimately with 199f2e0 (#1317).

/assign @smarterclayton

CC @sallyom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the smoke-config-updater branch September 11, 2018 20:02
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
* AGENT-245: DHCP only agent deployment

* Renamed vars

* Review fixes

* Generate agent config & install config seperately

* Use OVN-Kubernetes for SNO

* Add  _DHCP suffix to AGENT_E2E_TEST_SCENARIO var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants