add configMap for e2e-aws-smoke #1434
Conversation
openshift-ci-robot
added
the
size/XS
|
/assign @smarterclayton |
There was a problem hiding this comment.
These have to be different because the names can't collide with e2e-aws - this is for namespacing the keys in the target namespace ci-operator uses.
There was a problem hiding this comment.
It's template and target that have to be different. Secrets are fine as long as other jobs that create the secret with this name don't have different contents
sallyom
force-pushed
the
another-fix-for-enabling-smoke
branch
from
0ad8e7f to
56600df
Compare
sallyom
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sallyom, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@sallyom: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…onfig Catching up with 56600df (add configmap for e2e-aws-smoke, 2018-09-10, openshift#1434) and ultimately with 199f2e0 (openshift/install e2e-aws add run smoke tests, 2018-08-28, openshift#1317).
5 participants
@wking this should fix e2e-aws-smoke job, hopefully