Skip to content

ci-operator/step-registry/gather: Exclude empty-string "instance IDs" #14467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Jan 5, 2021
Merged

ci-operator/step-registry/gather: Exclude empty-string "instance IDs" #14467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ci-operator/step-registry/gather/gcp-console/gather-gcp-console-commands.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ then
cat "${SHARED_DIR}/gcp-instance-ids.txt" >> "${TMPDIR}/node-provider-IDs.txt"
fi

cat "${TMPDIR}/node-provider-IDs.txt" | sort | uniq | while read -r INSTANCE_ID
cat "${TMPDIR}/node-provider-IDs.txt" | sort | grep . | uniq | while read -r INSTANCE_ID
do
echo "Finding the zone for ${INSTANCE_ID}"
ZONE="$(
Expand All @@ -43,6 +43,7 @@ do
if test -z "${ZONE}"
then
echo "No zone found for ${INSTANCE_ID}, so not attempting to gather console logs"
continue
fi
echo "Gathering console logs for ${INSTANCE_ID} from ${ZONE}"
gcloud --format json compute instances get-serial-port-output --zone "${ZONE}" "${INSTANCE_ID}" > "${ARTIFACT_DIR}/${INSTANCE_ID}.json" &
Expand Down