Skip to content

ci-operator/step-registry/gather: Exclude empty-string "instance IDs" #14467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 5, 2021
Merged

ci-operator/step-registry/gather: Exclude empty-string "instance IDs" #14467

openshift-merge-robot merged 1 commit into from
Jan 5, 2021

Conversation

@wking
Copy link
Member

@wking wking commented Dec 19, 2020

I'm not quite sure where the empty line came from, but this job had:

2020/12/19 12:29:58 Executing pod "e2e-gcp-upgrade-gather-gcp-console"
2020/12/19 12:30:03 Container cp-secret-wrapper in pod e2e-gcp-upgrade-gather-gcp-console completed successfully
Activated service account credentials for: [do-not-delete-ci-provisioner@openshift-gce-devel-ci.iam.gserviceaccount.com]
Updated property [core/project].
Finding the zone for
No zone found for , so not attempting to gather console logs
Gathering console logs for  from
ERROR: (gcloud.compute.instances.get-serial-port-output) could not parse resource []
error: failed to execute wrapped command: exit status 1
2020/12/19 12:30:13 Container test in pod e2e-gcp-upgrade-gather-gcp-console failed, exit code 1, reason Error

The grep . will only match non-empty lines.

Also add a continue to the empty-zone branch, which I'd missed in 5d9d973 (#13398).

/assign @cgwalters

@wking
ci-operator/step-registry/gather: Exclude empty-string "instance IDs"
7e1a515 
I'm not quite sure where the empty line came from, but [1] had:

  2020/12/19 12:29:58 Executing pod "e2e-gcp-upgrade-gather-gcp-console"
  2020/12/19 12:30:03 Container cp-secret-wrapper in pod e2e-gcp-upgrade-gather-gcp-console completed successfully
  Activated service account credentials for: [do-not-delete-ci-provisioner@openshift-gce-devel-ci.iam.gserviceaccount.com]
  Updated property [core/project].
  Finding the zone for
  No zone found for , so not attempting to gather console logs
  Gathering console logs for  from
  ERROR: (gcloud.compute.instances.get-serial-port-output) could not parse resource []
  error: failed to execute wrapped command: exit status 1
  2020/12/19 12:30:13 Container test in pod e2e-gcp-upgrade-gather-gcp-console failed, exit code 1, reason Error

The 'grep .' will only match non-empty lines.

Also add a 'continue' to the empty-zone branch, which I'd missed in
5d9d973 (ci-operator/step-registry/gather/gcp-console: Gather
console logs on GCP, 2020-11-04, openshift#13398).

[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-e2e-gcp-upgrade-4.7/1340262366092201984#1:build-log.txt%3A171
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2020
@wking
Copy link
Member Author

wking commented Dec 20, 2020

Looks fine.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 20, 2020

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/kubevirt/common-templates/master/e2e-azure-nested-common-templates-unit-tests 7e1a515 link /test pj-rehearse
ci/rehearse/opendatahub-io/opendatahub-operator/master/operator-e2e 7e1a515 link /test pj-rehearse
ci/rehearse/kubevirt/kubevirt-ssp-operator/master/e2e-functests 7e1a515 link /test pj-rehearse
ci/rehearse/kubevirt/hyperconverged-cluster-operator/release-1.2/hco-e2e-image-index-gcp 7e1a515 link /test pj-rehearse
ci/rehearse/kubevirt/hyperconverged-cluster-operator/master/hco-e2e-image-index-gcp 7e1a515 link /test pj-rehearse
ci/prow/pj-rehearse 7e1a515 link /test pj-rehearse
ci/rehearse/opendatahub-io/odh-manifests/master/odh-manifests-e2e 7e1a515 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

petr-muller
petr-muller approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Trevor says it's fine. Let's merge this.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2021
vrutkovs
vrutkovs approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 5, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2021

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/kubevirt/common-templates/master/e2e-azure-nested-common-templates-unit-tests 7e1a515 link /test pj-rehearse
ci/rehearse/opendatahub-io/opendatahub-operator/master/operator-e2e 7e1a515 link /test pj-rehearse
ci/rehearse/openshift/cincinnati-operator/release-4.5/operator-e2e 7e1a515 link /test pj-rehearse
ci/rehearse/kubevirt/kubevirt-ssp-operator/master/e2e-functests 7e1a515 link /test pj-rehearse
ci/rehearse/kubevirt/hyperconverged-cluster-operator/release-1.2/hco-e2e-image-index-gcp 7e1a515 link /test pj-rehearse
ci/rehearse/openshift/openshift-controller-manager/master/e2e-gcp-builds 7e1a515 link /test pj-rehearse
ci/rehearse/kubevirt/hyperconverged-cluster-operator/master/hco-e2e-image-index-gcp 7e1a515 link /test pj-rehearse
ci/prow/pj-rehearse 7e1a515 link /test pj-rehearse
ci/rehearse/opendatahub-io/odh-manifests/master/odh-manifests-e2e 7e1a515 link /test pj-rehearse
ci/rehearse/kubevirt/ssp-operator/master/e2e-upgrade-functests 7e1a515 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0c85325 into openshift:master Jan 5, 2021
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 5, 2021

@wking: Updated the following 2 configmaps:

  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key gather-gcp-console-commands.sh using file ci-operator/step-registry/gather/gcp-console/gather-gcp-console-commands.sh
  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key gather-gcp-console-commands.sh using file ci-operator/step-registry/gather/gcp-console/gather-gcp-console-commands.sh
Details

In response to this:

I'm not quite sure where the empty line came from, but this job had:

2020/12/19 12:29:58 Executing pod "e2e-gcp-upgrade-gather-gcp-console"
2020/12/19 12:30:03 Container cp-secret-wrapper in pod e2e-gcp-upgrade-gather-gcp-console completed successfully
Activated service account credentials for: [do-not-delete-ci-provisioner@openshift-gce-devel-ci.iam.gserviceaccount.com]
Updated property [core/project].
Finding the zone for
No zone found for , so not attempting to gather console logs
Gathering console logs for  from
ERROR: (gcloud.compute.instances.get-serial-port-output) could not parse resource []
error: failed to execute wrapped command: exit status 1
2020/12/19 12:30:13 Container test in pod e2e-gcp-upgrade-gather-gcp-console failed, exit code 1, reason Error

The grep . will only match non-empty lines.

Also add a continue to the empty-zone branch, which I'd missed in 5d9d973 (#13398).

/assign @cgwalters

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking mentioned this pull request Jun 30, 2021
Merged
wking added a commit to wking/openshift-release that referenced this pull request Jun 30, 2021
@wking
ci-operator/step-registry/gather/aws-console: Exclude empty-string "i…
0a0e1ab 
…nstance IDs"

Like we did for GCP in 7e1a515 (ci-operator/step-registry/gather:
Exclude empty-string "instance IDs", 2020-12-19, openshift#14467).  In this
case, the empty-string example was [1]:

  Gathering console logs for
  /bin/bash: line 41: /logs/artifacts/: Is a directory

[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/19836/rehearse-19836-pull-ci-openshift-origin-release-4.9-e2e-aws-disruptive
@wking wking deleted the gather-gcp-console-fixups branch September 21, 2021 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@enxebre enxebre Awaiting requested review from enxebre

2 more reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@petr-muller petr-muller petr-muller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vrutkovs vrutkovs

@cgwalters cgwalters

@petr-muller petr-muller

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@wking @openshift-merge-robot @openshift-ci-robot @openshift-bot @vrutkovs @petr-muller @cgwalters