Skip to content

exporting cluster-profile of SNO in case we're using a 'sno' variant #14043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
osherdp wants to merge 1 commit into from
Closed

exporting cluster-profile of SNO in case we're using a 'sno' variant #14043

osherdp wants to merge 1 commit into from

Conversation

@osherdp
Copy link
Contributor

@osherdp osherdp commented Dec 3, 2020

No description provided.

@osherdp osherdp force-pushed the feature/export-sno-cluster-profile branch from 916e243 to 063e651 Compare December 3, 2020 10:57
@osherdp
Copy link
Contributor Author

osherdp commented Dec 3, 2020

/test pj-rehearse

@osherdp osherdp mentioned this pull request Dec 3, 2020
Merged
@osherdp
Copy link
Contributor Author

osherdp commented Dec 3, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2020
@osherdp osherdp force-pushed the feature/export-sno-cluster-profile branch from 063e651 to e94cdbd Compare December 3, 2020 12:38
@osherdp
Copy link
Contributor Author

osherdp commented Dec 3, 2020

openshift/enhancements#504
openshift/installer#4444
openshift/enhancements#543

eranco74
eranco74 reviewed Dec 3, 2020
View reviewed changes
Copy link
Contributor

@eranco74 eranco74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@osherdp
Copy link
Contributor Author

osherdp commented Dec 3, 2020

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2020
@osherdp
Copy link
Contributor Author

osherdp commented Dec 5, 2020

/retest

1 similar comment
@osherdp
Copy link
Contributor Author

osherdp commented Dec 6, 2020

/retest

@osherdp
Copy link
Contributor Author

osherdp commented Dec 6, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2020
@osherdp osherdp force-pushed the feature/export-sno-cluster-profile branch from e94cdbd to 974a1ef Compare December 6, 2020 09:21
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2020
@osherdp
Copy link
Contributor Author

osherdp commented Dec 6, 2020

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2020
@ravidbro
Copy link

ravidbro commented Dec 6, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 6, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eranco74, osherdp, ravidbro
To complete the pull request process, please assign sdodson after the PR has been reviewed.
You can assign the PR to them by writing /assign @sdodson in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@osherdp
Copy link
Contributor Author

osherdp commented Dec 7, 2020

/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 7, 2020

@osherdp: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-etcd-operator/master/e2e-disruptive 974a1ef link /test pj-rehearse
ci/rehearse/openshift/installer/release-4.4/e2e-azure-shared-vpc 974a1ef link /test pj-rehearse
ci/prow/pj-rehearse 974a1ef link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@osherdp
Copy link
Contributor Author

osherdp commented Dec 8, 2020

/assign @sdodson

@osherdp
Copy link
Contributor Author

osherdp commented Dec 15, 2020

not needed

@osherdp osherdp closed this Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhixson74 jhixson74 Awaiting requested review from jhixson74

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

2 more reviewers

@eranco74 eranco74 eranco74 left review comments

@ravidbro ravidbro ravidbro left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@sdodson sdodson

@eranco74 eranco74

@ravidbro ravidbro

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@osherdp @ravidbro @openshift-ci-robot @openshift-merge-robot @eranco74 @sdodson