Skip to content

add single-node variant for applying cluster profile of single node #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 5, 2021
Merged

add single-node variant for applying cluster profile of single node #114

openshift-merge-robot merged 1 commit into from
Jan 5, 2021

Conversation

@osherdp
Copy link
Contributor

@osherdp osherdp commented Dec 3, 2020 •
edited
Loading

Compliments openshift/release#14556
We want to apply cluster profile of single-node, which enables 1 node that acts as control plane and compute resource

@osherdp
Copy link
Contributor Author

osherdp commented Dec 8, 2020

/assign @smarterclayton

@osherdp
Copy link
Contributor Author

osherdp commented Dec 15, 2020

not needed

@osherdp osherdp closed this Dec 15, 2020
@osherdp osherdp reopened this Jan 3, 2021
@osherdp
Copy link
Contributor Author

osherdp commented Jan 3, 2021

/cc @eranco74 @romfreiman

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 3, 2021

@osherdp: GitHub didn't allow me to request PR reviews from the following users: eranco74, romfreiman.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @eranco74 @romfreiman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

smarterclayton
smarterclayton reviewed Jan 5, 2021
View reviewed changes
@osherdp osherdp force-pushed the feature/add-sno-variant branch from 1a89d0a to 86832e5 Compare January 5, 2021 19:46
@osherdp osherdp requested a review from smarterclayton January 5, 2021 20:03
@smarterclayton smarterclayton changed the title add sno variant for applying cluster profile of single node add single-node variant for applying cluster profile of single node Jan 5, 2021
@smarterclayton
Copy link
Contributor

smarterclayton commented Jan 5, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: osherdp, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit a3afda2 into openshift:master Jan 5, 2021
@eranco74
Copy link

eranco74 commented Jan 6, 2021

Allow deploying none HA cluster as described in openshift/enhancements#555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@osherdp @openshift-ci-robot @smarterclayton @eranco74 @openshift-merge-robot