Add aws-serial job for MCO

[fabianvf]

No description provided.

[yuqi-zhang]

/approve

[deads2k]

going to make sure the e2e-serial tests at least start running in the rehearse to know we got the right things.

[wking]

How often has the MCO broken serial tests? If this is a one-off, I'd consider always_run: false to save some CI-volume cost. This property is one that you can hand-edit in this file; it is not fed from the config YAML.

I'd also consider optional: true, to allow the MCO to merge PRs where serial tests were failing. But that's mostly to keep their throughput up if serial starts flaking out for some non-MCO reason, and if they only call in the serial tests occasionally (with an always_run: false change), requiring serial to pass or be explicitly /overriden seems reasonable too.

[deads2k]

How often has the MCO broken serial tests? If this is a one-off, I'd consider always_run: false to save some CI-volume cost. This property is one that you can hand-edit in this file; it is not fed from the config YAML.

Everyone will say they break it infrequently. I think it's low enough in the stack to warrant it and there's an explicit scaling test where the machine-api often suspects the MCO. It came up multiple times in 4.6.

[deads2k]

/lgtm

the correct tests ran

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, fabianvf, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/machine-config-operator/OWNERS [yuqi-zhang]
• ci-operator/jobs/openshift/machine-config-operator/OWNERS [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-robot]

@fabianvf: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/machine-config-operator/master/e2e-aws-serial	b462a16	link	/test pj-rehearse
ci/prow/pj-rehearse	b462a16	link	/test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@fabianvf: Updated the following 3 configmaps:

• job-config-master configmap in namespace ci at cluster api.ci using the following files:
  • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
• job-config-master configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-machine-config-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-master-presubmits.yaml
• ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
  • key openshift-machine-config-operator-master.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-master.yaml

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.