-
Notifications
You must be signed in to change notification settings - Fork 463
Revert "crio: drop infra container when possible" #2204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 6eb3789.
|
/hold for openshift/release#13435 to merge so we can see if this revert fixes the serial tests |
|
/test ci/prow/e2e-aws-serial |
|
@deads2k: The specified target(s) for
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
It has merged. If this goes green on aws-serial, we should merge this and plan the next attempt. |
|
/lgtm (I am not sure I have approval rights though...) |
yuqi-zhang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be gated on e2e-aws-serial anyways so we'll find out if this was the PR that broke it
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, haircommander, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel ... so this can potentially merge tonight |
|
/hold I will keep an eye on it, I still wanna see if e2e-aws-serial passes or fails before merging |
|
/retest |
|
this is the one /hold cancel |
|
/retest |
This reverts commit 6eb3789.
reverts #2177, one of two commits that merged before the permafail of e2e-serial on OOMs