Skip to content

Conversation

@petr-muller
Copy link
Member

@petr-muller petr-muller commented Aug 28, 2018

Build and promote an additional image to be used in Prow job config validation.

/cc @stevekuznetsov
/hold

Blocks: openshift/ci-operator-prowgen#6 (but they should be merged close together, because this PR without the ci-operator-prowgen one would prevent other ci-operator-prowgen PRs to be merged)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2018
@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2018
@stevekuznetsov
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2018
@openshift-merge-robot openshift-merge-robot merged commit c18cbb3 into openshift:master Aug 28, 2018
@openshift-ci-robot
Copy link
Contributor

@petr-muller: Updated the ci-operator-openshift-ci-operator-prowgen configmap using the following files:

  • key master.json using file ci-operator/config/openshift/ci-operator-prowgen/master.json
Details

In response to this:

Build and promote an additional image to be used in Prow job config validation.

/cc @stevekuznetsov
/hold

Blocks: openshift/ci-operator-prowgen#6 (but they should be merged close together, because this PR without the ci-operator-prowgen one would prevent other ci-operator-prowgen PRs to be merged)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@petr-muller petr-muller deleted the build-determinize branch August 28, 2018 15:13
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
This currently ends up as 4.1 for 4.10 release image strings...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants