This repository was archived by the owner on Jun 14, 2019. It is now read-only.
Add a simple program to make Prow job config ordering deterministic #6
+124
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/hold
This was referenced Aug 28, 2018
| @@ -0,0 +1,5 @@ | |||
| FROM centos:7 | |||
| LABEL maintainer="[email protected]" | |||
cmd/ci-operator-prowgen/main.go
Outdated
| "strings" | ||
|
|
||
| "github.com/ghodss/yaml" | ||
| jc "github.com/openshift/ci-operator-prowgen/pkg/jobconfig" |
Contributor
There was a problem hiding this comment.
nit: this group should be below the external imports
petr-muller
force-pushed
the
determinize
branch
from
a0b7889 to
3571013
Compare
Member
Author
|
addressed, thanks |
Contributor
|
/hold cancel |
openshift-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate pieces of original
ci-operator-prowgento a package and let both executable share them. Build a container for the new utility so that it can be used in Prow jobs overopenshift/release./cc @stevekuznetsov
/hold
Depends on: