Skip to content

openshift-installer-presubmits: Run go-lint on cmd/... and pkg/... #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Aug 29, 2018
Merged

openshift-installer-presubmits: Run go-lint on cmd/... and pkg/... #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci-operator/config/openshift/installer/master.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
{
"as": "unit",
"from": "src",
"commands": "go test ./installer/pkg/..."
"commands": "go test ./pkg/... ./installer/pkg/..."
Copy link
Contributor

@stevekuznetsov stevekuznetsov Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not ./... ?

Copy link
Member Author

@wking wking Aug 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not ./... ?

We are currently leaning on Go's test framework for smoke tests. We may drop those soon in favor of more e2e-aws coverage (#1271 is groundwork for this expansion), but until then we need to keep this job out of tests/smoke. A white-list like this is one way to do that.

There may also be blacklist approaches, but I think we'd need to include find in our invocation if we wanted to do that. Or maybe leaning on your go list suggestion?

}
],

Expand Down
5 changes: 2 additions & 3 deletions ci-operator/jobs/openshift/installer/openshift-installer-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,9 +294,8 @@ presubmits:
spec:
containers:
- args:
- ./hack/go-lint.sh
- installer/...
- tests/smoke
- -c
- ./hack/go-lint.sh $(go list -f '{{ .ImportPath }}' ./...)
command:
- sh
env:
Expand Down