Add a new full run of the presubmits and change the e2e-aws focus #1271
Conversation
Will allow us to better test while iterating
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
|
@smarterclayton: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| volumeMounts: | ||
| - name: job-definition | ||
| mountPath: /usr/local/e2e-aws-all | ||
| subPath: cluster-launch-installer-e2e.yaml |
There was a problem hiding this comment.
This is the same path used to define the e2e-aws job (which makes sense). But depending on how long the full tests take to run, we might want to make the expiration date offset configurable. #1103's 4 hours give a good buffer for e2e-aws (which takes ~40 minutes), but this job's full suite triggered here is at two hours and counting.
The registry/serial focus was a typo from e260fd9 (Add a new full run of the presubmits and change the e2e-aws focus, 2018-08-23, openshift#1271).
4 participants
Will allow us to better test while iterating