cluster-launch-installer-e2e: remove etcd nodes #1274
Conversation
etcd nodes have been removed from the installer.
openshift-ci-robot
added
the
size/M
|
Etcd nodes are being removed from installer here openshift/installer#168 |
|
Can we also remove |
|
Looks like we also want to remove |
|
@wking I'll tackle it here. |
Support for extra tags was removed in openshift/installer#88.
This was removed in: coreos/tectonic-installer#3262
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@wking @crawford hey guys -- if there is config in this repo that is |
|
@crawford: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I'm wondering if we shouldn't revert... |
|
I'm going to revert, because it broke CI. We'll try again when openshift/installer#168 is ready to try again. |
Until we can re-land [1] (which is currently reverted by [2]). With the etcd node pool still defined in the release template, we're getting [3]: time="2018-08-27T18:50:53Z" level=fatal msg="unrecognized role: etcd" With this commit, we ignore that entry (just as Go's JSON and YAML unmarshallers ignore other properties which aren't reflected in the target Go structures). A better long-term fix would probably be adding more structure to node pools, but I'm punting on that for now. [1]: openshift/release#1274 [2]: openshift/release#1284 [3]: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/168/pull-ci-origin-installer-e2e-aws/710/build-log.txt
Currently, IPv6 clusters do not synchronize their time with NTP because there's no external internet access. This is causing a newly enabled test to fail (`[sig-apps] [Feature:TTLAfterFinished] job should be deleted once it finishes after TTL seconds`).
This was added in openshift#1274 but doing this drops all the libvirt chains, which causes subsequent ansible libvirt setup tasks to fail.
7 participants
etcd nodes have been removed from the installer.