This repository was archived by the owner on Feb 5, 2020. It is now read-only.
*: remove tls_validity_period #3262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enxebre
previously approved these changes
Jun 6, 2018
squat
force-pushed
the
remove_tls_validity_period
branch
from
00a1aad to
70b671d
Compare
This commit removes the tls validity period option from the yaml config. This options is not used anywhere in terraform.
squat
commented
Jun 7, 2018
| NodePools `json:"-" yaml:"nodePools"` | ||
| Platform Platform `json:"tectonic_platform" yaml:"platform,omitempty"` | ||
| PullSecretPath string `json:"tectonic_pull_secret_path,omitempty" yaml:"pullSecretPath,omitempty"` | ||
| TLSValidityPeriod int `json:"tectonic_tls_validity_period,omitempty" yaml:"tlsValidityPeriod,omitempty"` |
Contributor
Author
There was a problem hiding this comment.
The only difference here is the removal of the TLSValidityPeriod field. The rest is white space.
enxebre
approved these changes
Jun 7, 2018
alexsomesan
approved these changes
Jun 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the tls validity period option from the yaml config.
This options is not used anywhere in terraform.
cc @trawler @spangenberg @enxebre