Skip to content

Image building and unit tests for cluster-api-provider-aws #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 3 commits into from
Aug 23, 2018
Merged

Image building and unit tests for cluster-api-provider-aws #1233

openshift-merge-robot merged 3 commits into from
Aug 23, 2018

Conversation

@paulfantom
Copy link
Contributor

@paulfantom paulfantom commented Aug 21, 2018 •
edited
Loading

Added jobs to build images and run unit tests with ci-operator.

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 21, 2018
@paulfantom
Copy link
Contributor Author

paulfantom commented Aug 21, 2018

/hold cancel

/assign @stevekuznetsov

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2018
@paulfantom
Copy link
Contributor Author

paulfantom commented Aug 22, 2018

/hold until #1214 gets merged

@petr-muller
Copy link
Member

petr-muller commented Aug 22, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2018
@bbguimaraes
Copy link
Contributor

bbguimaraes commented Aug 22, 2018

@paulfantom: commands have to be on a separate line.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2018
@paulfantom
Copy link
Contributor Author

paulfantom commented Aug 22, 2018

@bbguimaraes what do you mean?

@bbguimaraes
Copy link
Contributor

bbguimaraes commented Aug 22, 2018

The command won't be recognized if there's text after it on the same line:

/hold cancel text after it on the same line

stevekuznetsov
stevekuznetsov reviewed Aug 22, 2018
View reviewed changes
...r/jobs/openshift/cluster-api-provider-aws/openshift-cluster-api-provider-aws-presubmits.yaml Outdated
Copy link
Contributor

@stevekuznetsov stevekuznetsov Aug 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely want a --target=[images] presubmit as well

Copy link
Contributor Author

@paulfantom paulfantom Aug 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Added. 👍

Copy link
Contributor

@stevekuznetsov stevekuznetsov Aug 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest separate jobs

cluster/ci/config/prow/plugins.yaml Outdated
Copy link
Contributor

@stevekuznetsov stevekuznetsov Aug 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After #1229 you don't need these

Copy link
Contributor Author

@paulfantom paulfantom Aug 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even approve?

@paulfantom paulfantom force-pushed the cluster-api-provider-aws branch from 930e0dd to 9b44c5c Compare August 22, 2018 16:28
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2018
@paulfantom
Copy link
Contributor Author

paulfantom commented Aug 22, 2018

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2018
stevekuznetsov
stevekuznetsov reviewed Aug 22, 2018
View reviewed changes
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

we can split out jobs later

...r/jobs/openshift/cluster-api-provider-aws/openshift-cluster-api-provider-aws-presubmits.yaml Outdated
Copy link
Contributor

@stevekuznetsov stevekuznetsov Aug 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest separate jobs

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 22, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, petr-muller, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2018
@petr-muller
Copy link
Member

petr-muller commented Aug 23, 2018

We'll split the jobs when we fire up the generator anyway.

@petr-muller
Copy link
Member

petr-muller commented Aug 23, 2018

/test all

@openshift-merge-robot openshift-merge-robot merged commit 1193603 into openshift:master Aug 23, 2018
@paulfantom paulfantom deleted the cluster-api-provider-aws branch August 23, 2018 09:59
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 23, 2018

@paulfantom: Updated the following 2 configmaps:

  • job-config configmap using the following files:
    • key openshift-cluster-api-provider-aws-postsubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-aws/openshift-cluster-api-provider-aws-postsubmits.yaml
    • key openshift-cluster-api-provider-aws-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-aws/openshift-cluster-api-provider-aws-presubmits.yaml
  • plugins configmap using the following files:
    • key plugins.yaml using file cluster/ci/config/prow/plugins.yaml
Details

In response to this:

Added jobs to build images and run unit tests with ci-operator.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
@djzager
assisted-installer: do not set starting CSV (openshift#1233)
086c5fc 
With there being multiple releases of the assisted-service-operator,
starting at v0.0.1 is only going to cause headaches. This removes it
entirely and leaves it up to OLM which version to install first...which
if we set up our manifests correctly should always be the latest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@petr-muller petr-muller

@stevekuznetsov stevekuznetsov

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@paulfantom @petr-muller @bbguimaraes @openshift-ci-robot @stevekuznetsov @openshift-merge-robot