Skip to content

Conversation

@stevekuznetsov
Copy link
Contributor

  • trigger should do nothing when there are no jobs configured
  • blunderbuss should do nothing without an OWNERS file
  • golint is harmless

None consume GitHub tokens in the no-op case. We should collapse.

/cc @Kargakis @smarterclayton

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 21, 2018
Signed-off-by: Steve Kuznetsov <[email protected]>
@stevekuznetsov stevekuznetsov force-pushed the skuznets/DRY-plugin-config branch from 832bb97 to 858bf4c Compare August 21, 2018 00:33
@stevekuznetsov
Copy link
Contributor Author

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2018
@stevekuznetsov
Copy link
Contributor Author

@smarterclayton @Kargakis thoughts?

@0xmichalis
Copy link
Contributor

0xmichalis commented Aug 22, 2018 via email

@stevekuznetsov
Copy link
Contributor Author

Yeah useless, will kill it later

@stevekuznetsov stevekuznetsov added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2018
@openshift-merge-robot openshift-merge-robot merged commit 0e52077 into openshift:master Aug 22, 2018
@openshift-ci-robot
Copy link
Contributor

@stevekuznetsov: Updated the plugins configmap using the following files:

  • key plugins.yaml using file cluster/ci/config/prow/plugins.yaml
Details

In response to this:

  • trigger should do nothing when there are no jobs configured
  • blunderbuss should do nothing without an OWNERS file
  • golint is harmless

None consume GitHub tokens in the no-op case. We should collapse.

/cc @Kargakis @smarterclayton

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants