-
Notifications
You must be signed in to change notification settings - Fork 2.1k
DRY plugin config #1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRY plugin config #1229
Conversation
Signed-off-by: Steve Kuznetsov <[email protected]>
832bb97 to
858bf4c
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@smarterclayton @Kargakis thoughts? |
|
docs-no-retest is useless, right? Rest of the changes lgtm
…On Tue, Aug 21, 2018, 23:43 Steve Kuznetsov ***@***.***> wrote:
@smarterclayton <https://github.com/smarterclayton> @Kargakis
<https://github.com/kargakis> thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1229 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADuFfwAgY5jx9XdJ4WvYOsQ8zbruXGlwks5uTHDYgaJpZM4WE6QT>
.
|
|
Yeah useless, will kill it later |
|
@stevekuznetsov: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…penshift#1229) This reverts commit 4816c8b.
triggershould do nothing when there are no jobs configuredblunderbussshould do nothing without an OWNERS filegolintis harmlessNone consume GitHub tokens in the no-op case. We should collapse.
/cc @Kargakis @smarterclayton