Adding a new config and plugins for cluter-api-provider-kubevirt #12318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
Contributor
|
@bardielle retitle the PR, its about the cluter-api-provider-kubevirt and not the IPI provider |
bardielle
changed the title
bardielle
force-pushed
the
adding-kubevirt-ipi-provider
branch
from
048b10f to
879b6f0
Compare
Member
|
/uncc Please tag me when this PR is ready for review :) |
rgolangh
reviewed
Oct 1, 2020
Contributor
There was a problem hiding this comment.
I sent openshift/cluster-api-provider-kubevirt#3 to rename the file to Dockerfile.rhel
Contributor
Author
There was a problem hiding this comment.
Thanks I approved it
Contributor
Author
|
/retest |
bardielle
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
bardielle
changed the title
Contributor
Author
|
@petr-muller Please review this PR |
chenyosef
suggested changes
Oct 1, 2020
bardielle
force-pushed
the
adding-kubevirt-ipi-provider
branch
from
879b6f0 to
47b5979
Compare
chenyosef
approved these changes
Oct 1, 2020
Contributor
|
/assign @petr-muller |
petr-muller
reviewed
Oct 6, 2020
Member
petr-muller
left a comment
petr-muller
left a comment
There was a problem hiding this comment.
LGTM, two things:
- We've done a branch cut to 4.7 in the meantime, so some fields need to go from
4.6to4.7(I've used the suggestions to point them out). - You are not setting up automated merges, is that intentional?
.../openshift/cluster-api-provider-kubevirt/openshift-cluster-api-provider-kubevirt-master.yaml
Outdated
Show resolved
Hide resolved
.../openshift/cluster-api-provider-kubevirt/openshift-cluster-api-provider-kubevirt-master.yaml
Outdated
Show resolved
Hide resolved
.../openshift/cluster-api-provider-kubevirt/openshift-cluster-api-provider-kubevirt-master.yaml
Outdated
Show resolved
Hide resolved
Comment on lines
+6
to
+9
Member
There was a problem hiding this comment.
To prevent confusion -- the 4.6 should stay in this stanza for now.
Comment on lines
+24
to
+27
Member
There was a problem hiding this comment.
The 4.6 should stay here too (no change needed, just to prevent unnecessary changes)
Contributor
No, we should set it. @bardielle edit core-services/prow/02_config/_config.yaml and duplicate the |
bardielle
force-pushed
the
adding-kubevirt-ipi-provider
branch
from
47b5979 to
ebcda0e
Compare
petr-muller
approved these changes
Oct 6, 2020
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bardielle, chenyosef, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
@bardielle: Updated the following 7 configmaps:
DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.