Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Aug 17, 2018

We've had automatic Go lint CI via ci-operator since a50f4ba (#1177). But adding the plugin gives us a way to get inline comments about errors, which is more convenient than referring to an external failure document. For an example use-case, see here.

We've had automatic Go lint CI via ci-operator since a50f4ba (Prow:
Add golint to openshift/installer, 2018-08-15, openshift#1177).  But adding the
plugin gives us a way to get inline comments about errors, which is
more convenient than referring to an external failure document.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 17, 2018
@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2018
@openshift-merge-robot openshift-merge-robot merged commit 761af31 into openshift:master Aug 20, 2018
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the plugins configmap using the following files:

  • key plugins.yaml using file cluster/ci/config/prow/plugins.yaml
Details

In response to this:

We've had automatic Go lint CI via ci-operator since a50f4ba (#1177). But adding the plugin gives us a way to get inline comments about errors, which is more convenient than referring to an external failure document. For an example use-case, see here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the installer-golint-plugin branch August 27, 2018 16:58
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants