Prow: Add golint to openshift/installer #1177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
Contributor
Author
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
Member
|
/lgtm |
openshift-ci-robot
added
lgtm
Member
|
/lgtm |
openshift-bot
added
the
needs-rebase
Member
|
/hold cancel We can land this now that openshift/installer#118 has landed. This PR still needs a rebase though. |
openshift-ci-robot
removed
the
do-not-merge/hold
openshift-bot
removed
the
needs-rebase
Member
|
/lgtm |
Contributor
|
@alejovicu: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Aug 17, 2018
We've had automatic Go lint CI via ci-operator since a50f4ba (Prow: Add golint to openshift/installer, 2018-08-15, openshift#1177). But adding the plugin gives us a way to get inline comments about errors, which is more convenient than referring to an external failure document.
derekhiggins
pushed a commit
to derekhiggins/release
that referenced
this pull request
Oct 24, 2023
Adding nss_wrapper provides for a local, unprivileged passwd file to be specified, allowing the container to map the required user information to a random UID without having to modify the containers /etc/passwd file directly. Full explanation on https://access.redhat.com/articles/4859371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add golint for openshift/Installer
Do not merge until openshift/installer#118 is merged