ci-operator/config/openshift/release/openshift-release-master__ocp-4.4: Return to 4.4 upi-installer

[wking]

9b76797 (#10150) pulled in the 4.5 upi-installer for 4.4 CI because the aws client is new in 4.5. But it caused problems in UPI jobs, because steps consuming the upi-installer image ended up getting the 4.5 version and pulling 4.5 RHCOS:

2020-09-02 13:52:16+00:00 - Locating RHCOS image for release...
2020-09-02 13:52:16+00:00 - Configuring govc exports...
2020-09-02 13:52:16+00:00 - Checking if RHCOS OVA needs to be downloaded from https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.5/45.82.202008010929-0/x86_64/rhcos-45.82.202008010929-0-vmware.x86_64.ova...

However, the proxy jobs are currently explicitly pulling the 4.5 image straight from the ocp namespace:

$ git grep -B3 'tag: upi-installer' ci-operator/step-registry | grep proxy
ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml-  from_image:
ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml-    namespace: ocp
ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml-    name: "4.5"
ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml:    tag: upi-installer
ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml-  from_image:
ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml-    namespace: ocp
ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml-    name: "4.5"
ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml:    tag: upi-installer

So they shouldn't care about any upi-installer business in the release config file. Moving back to 4.4 there should fix the UPI portions of the jobs without breaking the proxy steps.

I'm not clear if we can entirely drop upi-installer from base_images or not, so I'm leaving it alone for now.

[jcpowermac]

I am lgtm but I am biased.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/release/OWNERS [petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@wking: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

• key openshift-release-master__ocp-4.4.yaml using file ci-operator/config/openshift/release/openshift-release-master__ocp-4.4.yaml

Details

In response to this:

9b76797 (#10150) pulled in the 4.5 upi-installer for 4.4 CI because the aws client is new in 4.5. But it caused problems in UPI jobs, because steps consuming the upi-installer image ended up getting the 4.5 version and pulling 4.5 RHCOS:

2020-09-02 13:52:16+00:00 - Locating RHCOS image for release...
2020-09-02 13:52:16+00:00 - Configuring govc exports...
2020-09-02 13:52:16+00:00 - Checking if RHCOS OVA needs to be downloaded from https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.5/45.82.202008010929-0/x86_64/rhcos-45.82.202008010929-0-vmware.x86_64.ova...

However, the proxy jobs are currently explicitly pulling the 4.5 image straight from the ocp namespace:

$ git grep -B3 'tag: upi-installer' ci-operator/step-registry | grep proxy
ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml-  from_image:
ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml-    namespace: ocp
ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml-    name: "4.5"
ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml:    tag: upi-installer
ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml-  from_image:
ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml-    namespace: ocp
ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml-    name: "4.5"
ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml:    tag: upi-installer

So they shouldn't care about any upi-installer business in the release config file. Moving back to 4.4 there should fix the UPI portions of the jobs without breaking the proxy steps.

I'm not clear if we can entirely drop upi-installer from base_images or not, so I'm leaving it alone for now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.