Skip to content

Bug 1845661: adding periodic proxy test using new workflow #10150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 16, 2020
Merged

Bug 1845661: adding periodic proxy test using new workflow #10150

openshift-merge-robot merged 1 commit into from
Jul 16, 2020

Conversation

@ewolinetz
Copy link
Contributor

@ewolinetz ewolinetz commented Jul 9, 2020 •
edited
Loading

@ewolinetz ewolinetz changed the title adding periodic proxy test using new workflow [WIP] Bug 1845661: adding periodic proxy test using new workflow Jul 9, 2020
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels Jul 9, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2020

@ewolinetz: This pull request references Bugzilla bug 1845661, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

[WIP] Bug 1845661: adding periodic proxy test using new workflow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 9, 2020
@ewolinetz ewolinetz force-pushed the proxy_periodic_multistep branch from 7f3c65a to 50688ce Compare July 9, 2020 16:56
@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 9, 2020

since i couldn't follow the slack thread in relation to this pr
/cc @stevekuznetsov @bparees

@ewolinetz ewolinetz changed the title [WIP] Bug 1845661: adding periodic proxy test using new workflow Bug 1845661: adding periodic proxy test using new workflow Jul 9, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2020
bparees
bparees reviewed Jul 9, 2020
View reviewed changes
ci-operator/jobs/openshift/release/openshift-release-master-periodics.yaml Outdated
Copy link
Contributor

@bparees bparees Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevekuznetsov since you don't want the informing label here, that means for now @ewolinetz needs to add this job to the release controller config to get testgrid-generator to include it in our dashboards, correct? Is there any negative consequence to him doing that?

Copy link
Contributor

@bparees bparees Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevekuznetsov bump

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 13, 2020

/test pj-rehearse

@bparees
Copy link
Contributor

bparees commented Jul 13, 2020

/approve

@ewolinetz still working out the rehearsal issues? once it passes it's good to go from my perspective.

we will then want to add this job to the release controller config as an informing job which will:

  1. cause the RC to run it on every new payload
  2. get it added to testgrid (once we also regen the testgrid config), which will get it into sippy

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2020
@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 14, 2020

@bparees yeah, trying to figure out why these rehearsal tests are failing when the original PR's rehearsal passed

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 14, 2020

it looks like we aren't running the setup steps as part of this workflow.. the artifacts dir only has the gather steps...

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 14, 2020

/refresh

@ewolinetz ewolinetz force-pushed the proxy_periodic_multistep branch 2 times, most recently from 3debff3 to 85e6475 Compare July 14, 2020 22:21
@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 15, 2020

/test pr-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 15, 2020

@ewolinetz: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test promrules
  • /test app-ci-config-dry
  • /test build-farm-consistency
  • /test build01-dry
  • /test build02-dry
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test config
  • /test core-dry
  • /test core-valid
  • /test correctly-sharded-config
  • /test generated-config
  • /test generated-dashboards
  • /test ordered-prow-config
  • /test owners
  • /test pj-rehearse
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test services-dry
  • /test services-valid
  • /test step-registry-shellcheck
  • /test vsphere-dry
  • /test pylint

Use /test all to run the following jobs:

  • pull-ci-openshift-release-master-app-ci-config-dry
  • pull-ci-openshift-release-master-build-farm-consistency
  • pull-ci-openshift-release-master-build01-dry
  • pull-ci-openshift-release-master-build02-dry
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-dry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-generated-dashboards
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-pj-rehearse
  • pull-ci-openshift-release-master-prow-config
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-master-services-dry
  • pull-ci-openshift-release-master-services-valid
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-master-vsphere-dry
Details

In response to this:

/test pr-rehearse

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 15, 2020

/test pj-rehearse

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 15, 2020

@bparees the rehearsal jobs are installing the cluster as expected -- it looks like the failures are from e2e test failures.

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 15, 2020

/retest

@ewolinetz ewolinetz force-pushed the proxy_periodic_multistep branch from 85e6475 to 4f8965b Compare July 15, 2020 16:31
@ewolinetz ewolinetz force-pushed the proxy_periodic_multistep branch from 4f8965b to 9b76797 Compare July 15, 2020 19:02
@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 15, 2020

@bparees looks like similar case here -- e2e tests aren't passing but the install completes

@ewolinetz
Copy link
Contributor Author

ewolinetz commented Jul 15, 2020

/test pj-rehearse

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 16, 2020

@ewolinetz: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/periodic-ci-openshift-release-master-ocp-4.6-e2e-aws-proxy-multistep 7f3c65ab0bc7beb2b7d7bd99c5938c29a980c229 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ocp-4.5-e2e-aws-proxy-multistep 7f3c65ab0bc7beb2b7d7bd99c5938c29a980c229 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ocp-4.4-e2e-aws-proxy-multistep 7f3c65ab0bc7beb2b7d7bd99c5938c29a980c229 link /test pj-rehearse
ci/rehearse/openshift/release/master/ocp-4.6-images 4675e10b8df35411b4809763fd28caabbbc7e6b5 link /test pj-rehearse
ci/rehearse/openshift/release/master/ocp-4.5-images 4675e10b8df35411b4809763fd28caabbbc7e6b5 link /test pj-rehearse
ci/rehearse/openshift/release/master/ocp-4.4-images 4675e10b8df35411b4809763fd28caabbbc7e6b5 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ocp-4.5-e2e-aws-proxy 9b76797 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ocp-4.4-e2e-aws-proxy 9b76797 link /test pj-rehearse
ci/prow/pj-rehearse 9b76797 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bparees
Copy link
Contributor

bparees commented Jul 16, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, ewolinetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 81a01a7 into openshift:master Jul 16, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 16, 2020

@ewolinetz: All pull requests linked via external trackers have merged: openshift/release#10150. Bugzilla bug 1845661 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1845661: adding periodic proxy test using new workflow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 16, 2020

@ewolinetz: Updated the following 11 configmaps:

  • job-config-4.4 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-release-4.4-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.4-periodics.yaml
  • job-config-4.5 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-release-release-4.5-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.5-periodics.yaml
  • job-config-4.6 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-release-release-4.6-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.6-periodics.yaml
  • job-config-4.6 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-release-4.6-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.6-periodics.yaml
  • job-config-4.7 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-release-release-4.7-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.7-periodics.yaml
  • job-config-4.7 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-release-4.7-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.7-periodics.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-periodics.yaml
  • job-config-4.4 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-release-release-4.4-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.4-periodics.yaml
  • job-config-4.5 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-release-4.5-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.5-periodics.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master__ocp-4.4.yaml using file ci-operator/config/openshift/release/openshift-release-master__ocp-4.4.yaml
    • key openshift-release-master__ocp-4.5.yaml using file ci-operator/config/openshift/release/openshift-release-master__ocp-4.5.yaml
    • key openshift-release-master__ocp-4.6.yaml using file ci-operator/config/openshift/release/openshift-release-master__ocp-4.6.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-release-master-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-periodics.yaml
Details

In response to this:

to address https://bugzilla.redhat.com/show_bug.cgi?id=1845661

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking mentioned this pull request Sep 2, 2020
Merged
wking added a commit to wking/openshift-release that referenced this pull request Sep 2, 2020
@wking
ci-operator/config/openshift/release/openshift-release-master__ocp-4.…
6fff2eb 
…4: Return to 4.4 upi-installer

9b76797 (adding periodic proxy test using new workflow, 2020-07-15, openshift#10150)
pulled in the 4.5 upi-installer for 4.4 CI because the the 'aws'
client is new in 4.5 [1].  But it caused problems in UPI jobs, because
steps consuming the upi-installer image ended up getting the 4.5
version and pulling 4.5 RHCOS [2]:

  2020-09-02 13:52:16+00:00 - Locating RHCOS image for release...
  2020-09-02 13:52:16+00:00 - Configuring govc exports...
  2020-09-02 13:52:16+00:00 - Checking if RHCOS OVA needs to be downloaded from https://releases-art-rhcos.svc.ci.openshift.org/art/storage/releases/rhcos-4.5/45.82.202008010929-0/x86_64/rhcos-45.82.202008010929-0-vmware.x86_64.ova...

However, the proxy jobs are currently explicitly pulling the 4.5 image
straight from the ocp namespace:

  $ git grep -B3 'tag: upi-installer' ci-operator/step-registry | grep proxy
  ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml-  from_image:
  ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml-    namespace: ocp
  ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml-    name: "4.5"
  ci-operator/step-registry/ipi/conf/aws/proxy/ipi-conf-aws-proxy-ref.yaml:    tag: upi-installer
  ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml-  from_image:
  ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml-    namespace: ocp
  ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml-    name: "4.5"
  ci-operator/step-registry/ipi/deprovision/proxy/ipi-deprovision-proxy-ref.yaml:    tag: upi-installer

So they shouldn't care about any upi-installer business in the release
config file.  Moving back to 4.4 there should fix the UPI portions of
the jobs without breaking the proxy steps.

I'm not clear if we can entirely drop upi-installer from base_images
or not, so I'm leaving it alone for now.

[1]: openshift/installer#3292
[2]: https://storage.googleapis.com/origin-ci-test/logs/periodic-ci-openshift-release-master-ocp-4.4-e2e-vsphere-upi/1301151427015479296/artifacts/e2e-vsphere-upi/upi-conf-vsphere-ova/container-logs/test.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees bparees left review comments

@bbguimaraes bbguimaraes Awaiting requested review from bbguimaraes

@droslean droslean Awaiting requested review from droslean

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

+1 more reviewer

@wking wking wking left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bparees bparees

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ewolinetz @openshift-ci-robot @bparees @wking @smarterclayton @openshift-merge-robot