openshift installer: add terraform fmt #1152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
sallyom
force-pushed
the
add-gotest-tf-fmt
branch
2 times, most recently
from
30ebced to
0f3c4b7
Compare
cluster/ci/config/prow/config.yaml
Outdated
Contributor
There was a problem hiding this comment.
You already have pull-ci-origin-installer-unit, why is this necessary?
Contributor
Author
There was a problem hiding this comment.
yes, I see that now, I see go test is called with ci-operator (https://github.com/openshift/release/blob/master/ci-operator/config/openshift/installer/master.json#L44) so I've removed that.
sallyom
force-pushed
the
add-gotest-tf-fmt
branch
3 times, most recently
from
ea8cdd7 to
00853b8
Compare
openshift-ci-robot
added
size/S
sallyom
changed the title
openshift-bot
added
the
needs-rebase
sallyom
force-pushed
the
add-gotest-tf-fmt
branch
from
00853b8 to
8aa2c87
Compare
openshift-bot
removed
the
needs-rebase
sallyom
force-pushed
the
add-gotest-tf-fmt
branch
from
8aa2c87 to
f67e06e
Compare
Contributor
Author
|
@bbguimaraes @stevekuznetsov this should be good to merge now, thanks |
Contributor
|
/lgtm |
Contributor
|
@sallyom: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Aug 14, 2018
These have moved into Prow presubmit jobs: * Terraform lint: openshift/release@82e00346 (Prow: Add Terraform Lint to openshift/installer, 2018-08-06, openshift/release#1124). * YAML lint: openshift/release@457be2cd (Added prow yaml-lint job description for installer repo, 2018-08-02, openshift/release#1138). * ShellCheck: openshift/release@e12a7a06 (Prow: Add shellcheck to openshift/installer, 2018-08-08, openshift/release#1131). * Terraform format: openshift/release@f67e06e4 (openshift installer: add terraform fmt, 2018-08-04, openshift/release#1152). * Go vet: openshift/release@71afdcca (Added go-vet prow job, 2018-08-14, openshift/release#1181). * Building the tarball: openshift/release@42a5a0d0 (add openshift/installer 'bazel build tarball' test to prow, 2018-08-13, openshift/release#1178).
derekhiggins
pushed a commit
to derekhiggins/release
that referenced
this pull request
Oct 24, 2023
* Adding the option to add certs to install-config.yaml * Add ADDITIONAL_TRUST_BUNDLE to the config_example.sh * Avoid additionalTrustBundle duplication & move from sed to awk When MIRROR_IMAGES is set or when using ipv6 (this is always true for ipv6) additionalTrustBundle section gets created, so give precedence to MIRROR_IMAGES CA * In case MIRROR_IMAGES is set, concat ADDITIONAL_TRUST_BUNDLE Co-authored-by: Aviel Yosef <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge until this merges: openshift/installer#97