Skip to content

Conversation

@rabugopsl
Copy link
Contributor

Adds yaml-lint job description to Prow

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2018
@petr-muller
Copy link
Member

/ok-to-test
/lgtm

Merge should probably wait until openshift/installer#101 is merged

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2018
@openshift-merge-robot openshift-merge-robot merged commit e2a94f4 into openshift:master Aug 3, 2018
@openshift-ci-robot
Copy link
Contributor

@rabugopsl: Updated the config configmap using the following files:

  • key config.yaml using file cluster/ci/config/prow/config.yaml
Details

In response to this:

Adds yaml-lint job description to Prow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@petr-muller
Copy link
Member

Dammit, I had no idea openshift/release does not need the approve label like most other repos do :/

@rabugopsl rabugopsl deleted the CORS-745_Move_yaml-lint_to_prow branch August 3, 2018 13:08
wking added a commit to wking/openshift-installer that referenced this pull request Aug 14, 2018
These have moved into Prow presubmit jobs:

* Terraform lint: openshift/release@82e00346 (Prow: Add Terraform Lint
  to openshift/installer, 2018-08-06, openshift/release#1124).
* YAML lint: openshift/release@457be2cd (Added prow yaml-lint job
  description for installer repo, 2018-08-02, openshift/release#1138).
* ShellCheck: openshift/release@e12a7a06 (Prow: Add shellcheck to
  openshift/installer, 2018-08-08, openshift/release#1131).
* Terraform format: openshift/release@f67e06e4 (openshift installer:
  add terraform fmt, 2018-08-04, openshift/release#1152).
* Go vet: openshift/release@71afdcca (Added go-vet prow job,
  2018-08-14, openshift/release#1181).
* Building the tarball: openshift/release@42a5a0d0 (add
  openshift/installer 'bazel build tarball' test to prow, 2018-08-13,
  openshift/release#1178).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants