Merge rukpak updates into main #86
Conversation
Removes rukpak manifests from platform-operators repo. Signed-off-by: dtfranz <dfranz@redhat.com>
…s+related objects Signed-off-by: dtfranz <dfranz@redhat.com>
Remove Rukpak
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@dtfranz: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
tmshort
left a comment
tmshort
left a comment
There was a problem hiding this comment.
I ignored the vendor directory.
/lgtm
| if err := c.Get(ctx, types.NamespacedName{Name: clusteroperator.AggregateResourceName}, co); err != nil { | ||
| return false, err | ||
| } | ||
| return len(co.Status.RelatedObjects) == 4, nil |
There was a problem hiding this comment.
Too bad this can't be an enumeration or calculated value.
|
/approved |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtfranz, joelanford, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
4 participants
No description provided.