Skip to content

Conversation

@dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Jun 12, 2023

Removes rukpak manifests from platform-operators repo.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Removes rukpak manifests from platform-operators repo.

Signed-off-by: dtfranz <dfranz@redhat.com>
@dtfranz
Copy link
Contributor Author

dtfranz commented Jun 12, 2023

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

@dtfranz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@joelanford
Copy link
Member

joelanford commented Jun 12, 2023

This looks right to me. As soon as we merge this, rukpak will be unavailable in 4.14 pre-release builds. There's some interest in the service delivery org to try out rukpak, potentially in 4.14 release builds.

Ideally we minimize the time that rukpak does not appear in the 4.14 payload. However if it is unavoidable, we can direct SD to 4.13 instead.

This is now merging into a staging branch, so it doesn't affect the 4.14 payload.

…s+related objects

Signed-off-by: dtfranz <dfranz@redhat.com>
@dtfranz dtfranz changed the base branch from main to olmv1-devel June 21, 2023 18:49
@dtfranz dtfranz changed the title WIP: Remove Rukpak Remove Rukpak Jun 21, 2023
@dtfranz dtfranz marked this pull request as ready for review June 21, 2023 18:50
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2023
@openshift-ci openshift-ci bot requested review from ankitathomas and tmshort June 21, 2023 18:51
@joelanford
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtfranz, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit 191856f into openshift:olmv1-devel Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants