Skip to content

controllers: Set Progressing=False during success states #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Sep 9, 2022
Merged

controllers: Set Progressing=False during success states #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion controllers/aggregated_clusteroperator_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ func (a *AggregatedClusterOperatorReconciler) Reconcile(ctx context.Context, req
if len(poList.Items) == 0 {
// No POs on cluster, everything is fine
coBuilder.WithAvailable(openshiftconfigv1.ConditionTrue, "No POs are present in the cluster", "NoPOsFound")
coBuilder.WithProgressing(openshiftconfigv1.ConditionTrue, "No POs are present in the cluster")
coBuilder.WithProgressing(openshiftconfigv1.ConditionFalse, "No POs are present in the cluster")
return ctrl.Result{}, nil
}

Expand All @@ -90,6 +90,7 @@ func (a *AggregatedClusterOperatorReconciler) Reconcile(ctx context.Context, req
return ctrl.Result{}, nil
}
coBuilder.WithAvailable(openshiftconfigv1.ConditionTrue, "All POs in a successful state", "POsHealthy")
coBuilder.WithProgressing(openshiftconfigv1.ConditionFalse, "All POs in a successful state")
Copy link
Contributor

@tylerslaton tylerslaton Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have a follow-up to turn PO into PlatformOperators. Not blocking though.

Copy link
Contributor Author

@timflannagan timflannagan Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, agreed. We should also move these to constant variables so there's less potential for skew between the implementation and test code.


return ctrl.Result{}, nil
}
Expand Down