controllers: Set Progressing=False during success states #53
Conversation
Signed-off-by: timflannagan <[email protected]>
openshift-ci
bot
added
the
approved
|
This is a no-op. Adding the required labels /label px-approved |
openshift-ci
bot
added
px-approved
| return ctrl.Result{}, nil | ||
| } | ||
| coBuilder.WithAvailable(openshiftconfigv1.ConditionTrue, "All POs in a successful state", "POsHealthy") | ||
| coBuilder.WithProgressing(openshiftconfigv1.ConditionFalse, "All POs in a successful state") |
There was a problem hiding this comment.
We should probably have a follow-up to turn PO into PlatformOperators. Not blocking though.
There was a problem hiding this comment.
Yeah, agreed. We should also move these to constant variables so there's less potential for skew between the implementation and test code.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan, tylerslaton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Moving this out of the #23 PR. This was needed as the aggregate CO was blocking cluster rollout despite reporting an Available=True condition when no POs had been installed.
Signed-off-by: timflannagan [email protected]