Skip to content

[release-4.7] Bug 2047325: Fix node connectivity to service backed by egress IP pods#946

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.7from
flavio-fernandes:bugfix/2047325
Feb 23, 2022
Merged

[release-4.7] Bug 2047325: Fix node connectivity to service backed by egress IP pods#946
openshift-merge-robot merged 1 commit intoopenshift:release-4.7from
flavio-fernandes:bugfix/2047325

Conversation

@flavio-fernandes
Copy link
Copy Markdown
Contributor

@flavio-fernandes flavio-fernandes commented Feb 8, 2022

This is a cherry-pick of #886

Legacy commit using ovn-nbctl for the implementation. This commit will
be used for backports to older versions.

The host network couldn't connect to services backed by egress IP
matching pods since the return packets would get forwarded to the egress
nodes for these pods because of the routing policies specified for the
egress matching pods. This would in turn break the connection. Hence
what we need is to specify routing policies which forces the packet to
go to the originating GR instead of getting routed to the egress node
GR.

Conflicts:
go-controller/pkg/ovn/egressip_test.go

Signed-off-by: Flavio Fernandes flaviof@redhat.com
Co-authored-by: Alexander Constantinescu aconstan@redhat.com
(cherry picked from commit 49f4fef)

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Feb 8, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 8, 2022

@flavio-fernandes: This pull request references Bugzilla bug 2047325, which is invalid:

  • expected dependent Bugzilla bug 2043757 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.7] Bug 2047325: Fix node connectivity to service backed by egress IP pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 8, 2022
@openshift-ci openshift-ci bot requested review from aojea and tssurya February 8, 2022 19:07
@flavio-fernandes
Copy link
Copy Markdown
Contributor Author

flavio-fernandes commented Feb 9, 2022

/bugzilla refresh

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 9, 2022

@flavio-fernandes: This pull request references Bugzilla bug 2047325, which is invalid:

  • expected dependent Bugzilla bug 2043757 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavio-fernandes
Copy link
Copy Markdown
Contributor Author

flavio-fernandes commented Feb 9, 2022

/retest

@dcbw
Copy link
Copy Markdown
Contributor

dcbw commented Feb 11, 2022

@flavio-fernandes

pkg/ovn/egressip.go:754:42: cannot use v4ClusterSubnet (type *"net".IPNet) as type []*"net".IPNet in argument to oc.createDefaultNoRerouteServicePolicies
pkg/ovn/egressip.go:754:42: cannot use v6ClusterSubnet (type *"net".IPNet) as type []*"net".IPNet in argument to oc.createDefaultNoRerouteServicePolicies

@flavio-fernandes
Copy link
Copy Markdown
Contributor Author

flavio-fernandes commented Feb 12, 2022

@flavio-fernandes

pkg/ovn/egressip.go:754:42: cannot use v4ClusterSubnet (type *"net".IPNet) as type []*"net".IPNet in argument to oc.createDefaultNoRerouteServicePolicies
pkg/ovn/egressip.go:754:42: cannot use v6ClusterSubnet (type *"net".IPNet) as type []*"net".IPNet in argument to oc.createDefaultNoRerouteServicePolicies

oh. thanks!

-- flaviof

@alexanderConstantinescu @flavio-fernandes
Legacy: fix node connectivity to service backed by egress IP pods
4e50fc5 
Legacy commit using ovn-nbctl for the implementation. This commit will
be used for backports to older versions.

The host network couldn't connect to services backed by egress IP
matching pods since the return packets would get forwarded to the egress
nodes for these pods because of the routing policies specified for the
egress matching pods. This would in turn break the connection. Hence
what we need is to specify routing policies which forces the packet to
go to the originating GR instead of getting routed to the egress node
GR.

Conflicts:
  go-controller/pkg/ovn/egressip.go
  go-controller/pkg/ovn/egressip_test.go

Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
Co-authored-by: Alexander Constantinescu <aconstan@redhat.com>
(cherry picked from commit 49f4fef)
@flavio-fernandes
Copy link
Copy Markdown
Contributor Author

flavio-fernandes commented Feb 14, 2022

@flavio-fernandes

pkg/ovn/egressip.go:754:42: cannot use v4ClusterSubnet (type *"net".IPNet) as type []*"net".IPNet in argument to oc.createDefaultNoRerouteServicePolicies
pkg/ovn/egressip.go:754:42: cannot use v6ClusterSubnet (type *"net".IPNet) as type []*"net".IPNet in argument to oc.createDefaultNoRerouteServicePolicies

pushed fix commit. thank you again, @dcbw . @trozet PTAL

@flavio-fernandes
Copy link
Copy Markdown
Contributor Author

flavio-fernandes commented Feb 14, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 14, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 14, 2022

@flavio-fernandes: This pull request references Bugzilla bug 2047325, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2043757 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2043757 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 14, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 14, 2022 •
edited
Loading

@flavio-fernandes: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack 4e50fc5 link false /test e2e-metal-ipi-ovn-dualstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@flavio-fernandes
Copy link
Copy Markdown
Contributor Author

flavio-fernandes commented Feb 14, 2022

/assign @trozet

@trozet
Copy link
Copy Markdown
Contributor

trozet commented Feb 21, 2022

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Feb 21, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2022
@flavio-fernandes
Copy link
Copy Markdown
Contributor Author

flavio-fernandes commented Feb 21, 2022

/retest-required

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@flavio-fernandes
Copy link
Copy Markdown
Contributor Author

flavio-fernandes commented Feb 22, 2022

hello @anuragthehatter @zhaozhanqi. Can you look into adding the cherry-pick-approved label to this pr, please?
This is a cherry-pick of pr #922 which I think you looked into before.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 22, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 23, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 23, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 23, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@huiran0826
Copy link
Copy Markdown
Contributor

huiran0826 commented Feb 23, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 23, 2022
@huiran0826
Copy link
Copy Markdown
Contributor

huiran0826 commented Feb 23, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit 0591214 into openshift:release-4.7 Feb 23, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 23, 2022

@flavio-fernandes: All pull requests linked via external trackers have merged:

Bugzilla bug 2047325 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.7] Bug 2047325: Fix node connectivity to service backed by egress IP pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavio-fernandes flavio-fernandes deleted the bugfix/2047325 branch February 28, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aojea aojea Awaiting requested review from aojea

@tssurya tssurya Awaiting requested review from tssurya

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@trozet trozet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@flavio-fernandes @dcbw @trozet @openshift-bot @huiran0826 @openshift-merge-robot @alexanderConstantinescu