Skip to content

Bug 1950471: Purge only the lprs with nexthops of the same family of new nexthop #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
May 5, 2021
Merged

Bug 1950471: Purge only the lprs with nexthops of the same family of new nexthop #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion go-controller/pkg/ovn/gateway_init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,12 @@ func syncPolicyBasedRoutes(nodeName string, matches sets.String, priority, nexth
for _, policyCompare := range policiesCompare {
if strings.Contains(policyCompare, fmt.Sprintf("%s\"", nodeName)) {
// if the policy is for this node and has the wrong mgmtPortIP as nexthop, remove it
// FIXME we currently assume that foundNexthops is a single ip, this may
// change in the future.
foundNexthops := strings.Split(policyCompare, ",")[2]
if foundNexthops != "" && utilnet.IsIPv6String(foundNexthops) != utilnet.IsIPv6String(nexthop) {
continue
}
if !strings.Contains(foundNexthops, nexthop) {
uuid := strings.Split(policyCompare, ",")[0]
if err := deletePolicyBasedRoutes(uuid, priority); err != nil {
Expand All @@ -642,7 +647,6 @@ func syncPolicyBasedRoutes(nodeName string, matches sets.String, priority, nexth
desiredMatchFound = true
break
}
break
}
// if the policy is for this node/priority and does not contain a valid match, remove it
if !desiredMatchFound {
Expand Down