Bug 1950471: Purge only the lprs with nexthops of the same family of new nexthop by fedepaol · Pull Request #516 · openshift/ovn-kubernetes

fedepaol · 2021-04-26T14:27:29Z

For each node, we add pbrs for each node subnet. When syncing pbrs, we purge
not expected rules. In case of dual stack, we are mistakenly purging the
rules that were added because of the subnet belonging to the other ip
family.
Here, we compare the family of the nexthop with the family of the new
nexthop and apply the logic only if they match.

For each node, we add pbrs for each node subnet. When syncing pbrs, we purge not expected rules. In case of dual stack, we are mistakenly purging the rules that were added because of the subnet belonging to the other ip family. Here, we compare the family of the nexthop with the family of the new nexthop and apply the logic only if they match. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>

openshift-ci-robot · 2021-04-26T14:27:35Z

@fedepaol: This pull request references Bugzilla bug 1950471, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.8.0) matches configured target release for branch (4.8.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

Details

In response to this:

Bug 1950471: Purge only the lprs with nexthops of the same family of new nexthop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fedepaol · 2021-04-26T14:27:39Z

/cc @trozet

fedepaol · 2021-04-26T16:35:44Z

/retest

dcbw · 2021-04-27T01:47:52Z

Lots of CI job lease failures

/retest
/lgtm
/approve

openshift-ci-robot · 2021-04-27T01:48:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, fedepaol

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dcbw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-04-27T03:05:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T03:43:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T03:53:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T04:17:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T05:17:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T05:29:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T05:41:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T05:53:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T06:05:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T07:29:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T07:55:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T08:20:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T09:38:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T09:50:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T10:02:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T10:30:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-27T11:41:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-04T08:42:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-04T09:08:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-04T09:33:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-04T09:47:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-04T10:11:59Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-04T10:36:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-04T11:24:09Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-04T11:36:21Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-04T11:48:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

trozet · 2021-05-04T12:13:21Z

/override ci/prow/e2e-metal-ipi-ovn-dualstack

trozet · 2021-05-04T12:13:37Z

/override ci/prow/e2e-metal-ipi-ovn-ipv6

openshift-ci-robot · 2021-05-04T12:15:16Z

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-metal-ipi-ovn-ipv6

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-05-04T12:16:41Z

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-metal-ipi-ovn-dualstack

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-dualstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-04T15:24:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-04T15:36:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

trozet · 2021-05-04T19:19:02Z

/override ci/prow/e2e-metal-ipi-ovn-ipv6

openshift-ci-robot · 2021-05-04T19:27:52Z

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-metal-ipi-ovn-ipv6

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-05-04T21:18:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-05T02:03:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-05T03:09:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-05T03:47:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-05T04:01:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-05T05:57:57Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-05-05T07:11:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

trozet · 2021-05-05T13:46:45Z

/override ci/prow/e2e-gcp-ovn

openshift-ci-robot · 2021-05-05T13:47:43Z

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-gcp-ovn

Details

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-05-05T13:48:23Z

@fedepaol: All pull requests linked via external trackers have merged:

Bugzilla bug 1950471 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1950471: Purge only the lprs with nexthops of the same family of new nexthop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fedepaol · 2021-05-20T12:02:15Z

/cherry-pick release-4.7

openshift-cherrypick-robot · 2021-05-20T12:02:49Z

@fedepaol: #516 failed to apply on top of branch "release-4.7":

Applying: Purge only the lprs with nexthops of the same family of new nexthop
Using index info to reconstruct a base tree...
M	go-controller/pkg/ovn/gateway_init.go
Falling back to patching base and 3-way merge...
Auto-merging go-controller/pkg/ovn/gateway_init.go
CONFLICT (content): Merge conflict in go-controller/pkg/ovn/gateway_init.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Purge only the lprs with nexthops of the same family of new nexthop
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick release-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 26, 2021

openshift-ci-robot requested review from danwinship and trozet April 26, 2021 14:27

openshift-ci-robot assigned dcbw Apr 27, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2021

openshift-merge-robot merged commit ef5d08b into openshift:master May 5, 2021

Conversation

fedepaol commented Apr 26, 2021

Uh oh!

openshift-ci-robot commented Apr 26, 2021

Uh oh!

fedepaol commented Apr 26, 2021

Uh oh!

fedepaol commented Apr 26, 2021

Uh oh!

dcbw commented Apr 27, 2021

Uh oh!

openshift-ci-robot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented Apr 27, 2021

Uh oh!

openshift-bot commented May 4, 2021

Uh oh!

openshift-bot commented May 4, 2021

Uh oh!

openshift-bot commented May 4, 2021

Uh oh!

openshift-bot commented May 4, 2021

Uh oh!

openshift-bot commented May 4, 2021

Uh oh!

openshift-bot commented May 4, 2021

Uh oh!

openshift-bot commented May 4, 2021

Uh oh!

openshift-bot commented May 4, 2021

Uh oh!

openshift-bot commented May 4, 2021

Uh oh!

trozet commented May 4, 2021

Uh oh!

trozet commented May 4, 2021

Uh oh!

openshift-ci-robot commented May 4, 2021

Uh oh!

openshift-ci-robot commented May 4, 2021

Uh oh!

openshift-bot commented May 4, 2021

Uh oh!

openshift-bot commented May 4, 2021

Uh oh!

trozet commented May 4, 2021

Uh oh!

openshift-ci-robot commented May 4, 2021