Skip to content

[release-4.21] OCPBUGS-77147: Minimize ACLs by combining ipBlocks into single ACL#2995

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
pperiyasamy:reduce-acls-np-ipblocks-4.21
Mar 5, 2026
Merged

[release-4.21] OCPBUGS-77147: Minimize ACLs by combining ipBlocks into single ACL#2995
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
pperiyasamy:reduce-acls-np-ipblocks-4.21

Conversation

@pperiyasamy
Copy link
Copy Markdown
Member

Manual cherry-pick of 14b7309 from PR #2978. No conflicts.

Combine all ipBlocks in a NetworkPolicy rule into single
ACL instead of creating one ACL per ipBlock.
This reduces ACL bloat when policy having multiple ipBlocks
for ingress/egress rules.

Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com>
(cherry picked from commit fd27015)
(cherry picked from commit 14b7309)
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 23, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@pperiyasamy: This pull request references Jira Issue OCPBUGS-77147, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-76500 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry-pick of 14b7309 from PR #2978. No conflicts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pperiyasamy pperiyasamy changed the title OCPBUGS-77147: Minimize ACLs by combining ipBlocks into single ACL [release-4.21] OCPBUGS-77147: Minimize ACLs by combining ipBlocks into single ACL Feb 23, 2026
@pperiyasamy
Copy link
Copy Markdown
Member Author

/hold

@arkadeepsen
Copy link
Copy Markdown
Member

/retest-required

@liqcui
Copy link
Copy Markdown
Contributor

liqcui commented Mar 3, 2026

/verified by @liqcui

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 3, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@liqcui: This PR has been marked as verified by @liqcui.

Details

In response to this:

/verified by @liqcui

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pperiyasamy
Copy link
Copy Markdown
Member Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 3, 2026

@pperiyasamy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-hypershift 21ef647 link true /test e2e-aws-ovn-hypershift
ci/prow/security 21ef647 link false /test security
ci/prow/e2e-aws-ovn-edge-zones 21ef647 link true /test e2e-aws-ovn-edge-zones
ci/prow/qe-perfscale-payload-control-plane-6nodes 21ef647 link true /test qe-perfscale-payload-control-plane-6nodes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@arkadeepsen
Copy link
Copy Markdown
Member

/test e2e-aws-ovn-hypershift

@arkadeepsen
Copy link
Copy Markdown
Member

/payload 4.21 ci blocking
/payload 4.21 nightly blocking

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 4, 2026

@arkadeepsen: trigger 5 job(s) of type blocking for the ci release of OCP 4.21

  • periodic-ci-openshift-release-main-ci-4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-main-ci-4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-main-ci-4.21-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aks
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/adceb290-1790-11f1-8bdc-1dcdf63e7ecb-0

trigger 14 job(s) of type blocking for the nightly release of OCP 4.21

  • periodic-ci-openshift-release-main-nightly-4.21-e2e-aws-ovn-serial-1of2
  • periodic-ci-openshift-release-main-nightly-4.21-e2e-aws-ovn-serial-2of2
  • periodic-ci-openshift-release-main-ci-4.21-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-main-ci-4.21-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-main-ci-4.21-e2e-aws-ovn-techpreview-serial-1of3
  • periodic-ci-openshift-release-main-ci-4.21-e2e-aws-ovn-techpreview-serial-2of3
  • periodic-ci-openshift-release-main-ci-4.21-e2e-aws-ovn-techpreview-serial-3of3
  • periodic-ci-openshift-release-main-nightly-4.21-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-main-nightly-4.21-e2e-aws-ovn-upgrade-fips-no-nat-instance
  • periodic-ci-openshift-release-main-ci-4.21-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-main-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-main-nightly-4.21-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-main-nightly-4.21-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/adceb290-1790-11f1-8bdc-1dcdf63e7ecb-1

@arkadeepsen
Copy link
Copy Markdown
Member

/test e2e-aws-ovn-hypershift

@arkadeepsen
Copy link
Copy Markdown
Member

/payload-job periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aks
/payload-job periodic-ci-openshift-release-main-ci-4.21-e2e-azure-ovn-upgrade

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 4, 2026

@arkadeepsen: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aks
  • periodic-ci-openshift-release-main-ci-4.21-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a1f61be0-17bb-11f1-9eb4-872774376a78-0

@arkadeepsen
Copy link
Copy Markdown
Member

/payload-job periodic-ci-openshift-release-main-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade
/payload-job periodic-ci-openshift-release-main-nightly-4.21-e2e-metal-ipi-ovn-bm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 4, 2026

@arkadeepsen: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-release-main-nightly-4.21-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/19cb0ae0-17c1-11f1-87ed-c998b64a068d-0

@openshift-ci openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Mar 4, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 4, 2026

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-aws-ovn-edge-zones, ci/prow/qe-perfscale-payload-control-plane-6nodes

Details

In response to this:

Overriding based on known issues: https://redhat-internal.slack.com/archives/GQ0CU2623/p1772633899059509?thread_ts=1772627887.252139&cid=GQ0CU2623
/override ci/prow/e2e-aws-ovn-edge-zones
/override ci/prow/qe-perfscale-payload-control-plane-6nodes
/lgtm
/label backport-risk-assessed

/hold
@pperiyasamy @arkadeepsen please feel free to remove the hold once the PR merges in upstream and we get a green signal from the payload jobs that are running.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tssurya
Copy link
Copy Markdown
Contributor

tssurya commented Mar 5, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@tssurya: This pull request references Jira Issue OCPBUGS-77147, which is invalid:

  • expected dependent Jira Issue OCPBUGS-76500 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liqcui
Copy link
Copy Markdown
Contributor

liqcui commented Mar 5, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@liqcui: This pull request references Jira Issue OCPBUGS-77147, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead
  • expected dependent Jira Issue OCPBUGS-76500 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liqcui
Copy link
Copy Markdown
Contributor

liqcui commented Mar 5, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 5, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@liqcui: This pull request references Jira Issue OCPBUGS-77147, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-76500 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-76500 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 5, 2026
@openshift-ci openshift-ci Bot requested a review from anuragthehatter March 5, 2026 13:01
@kyrtapz
Copy link
Copy Markdown
Contributor

kyrtapz commented Mar 5, 2026

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 147bc2e into openshift:release-4.21 Mar 5, 2026
29 of 30 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@pperiyasamy: Jira Issue Verification Checks: Jira Issue OCPBUGS-77147
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77147 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Manual cherry-pick of 14b7309 from PR #2978. No conflicts.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.