-
Notifications
You must be signed in to change notification settings - Fork 173
NO-JIRA: Bump OVN to 25.03 #2701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@kyrtapz: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
|
/retest |
|
Hi @kyrtapz, This is a list of relevant bug fixes and new core OVN features picked up by the bump: It would be great if you could add that to the commit message. Thanks, |
A list of relevant bug fixes and new core OVN features picked up by the bump: Bug fixes: ========== - logical-fields: Fix IPv6 dp flow explosion caused by ip6.mcast_rsvd. (#FDP-1557) https://issues.redhat.com/browse/FDP-1557 - controller: Slightly optimize the runtime_data handler for sb_ro. - Revert "northd: Don't skip the unSNAT stage for traffic towards VIPs." - fixes HWOL for node port traffic with NVidia NICs - controller: Install QoS rules even on 'system' ports. (#FDP-1472) https://issues.redhat.com/browse/FDP-1472 - controller: Make sure we run engine_cleanup after thread destroy. - northd: Sample_Collector.set_ids can actually be 32-bit values. New Features: ============= - Added support to choose selection methods - dp_hash or hash (with specified hash fields) for ECMP routes while choosing nexthop. - Added support for Spine-Leaf topology of logical switches by adding a new LSP type 'switch' that can directly connect two logical switches. Supported for both distributed and transit switches. - SSL/TLS: * TLSv1 and TLSv1.1 protocols are deprecated and disabled by default on OpenFlow and database connections. Use --ssl-protocols to turn them back on. Support will be fully removed in the next release. * OpenSSL 1.1.1 or newer is now required for SSL/TLS support. * The protocol list in --ssl-protocols or corresponding database column now supports specifying simple protocol ranges like: - "TLSv1-TLSv1.2" to enable all protocols between TLSv1 and TLSv1.2. - "TLSv1.2+" to enable protocol TLSv1.2 and later. The value must be a list of protocols or exactly one protocol range. * Added explicit support for TLSv1.3. It can now be enabled via --ssl-protocols (TLSv1.3 was supported in earlier versions only when this option was not set). TLS ciphersuites for TLSv1.3 and later can be configured via --ssl-ciphersuites (--ssl-ciphers only applies to TLSv1.2 and earlier). - Add "arp-nd-max-timeout-sec" config option to vswitchd external-ids to configure the interval (in seconds) between ovn-controller originated ARP/ND packets used for tracking ECMP next hop MAC addresses. - Auto flush ECMP symmetric reply connection states when an ECMP route is removed by the CMS. This behavior is controlled by the "ecmp_nexthop_monitor_enable" config option in the NB_Global table. Disabled by default. - Improved handling of IPv6 traffic by enabling address prefix tracking in OVS for both IPv4 and IPv6 addresses, whenever possible, reducing the amount of IPv6 datapath flows. - Add concept of Transit Routers, users are now allowed to specify options:requested-chassis for router ports; if the chassis is remote then the router port will behave as a remote port. - Added a new ACL option "persist-established" that allows for established connections to bypass ACL matching. This way, if an ACL match changes, traffic on the established connection can still pass. - Logical router policies can now be arranged in chains. Using the new "jump" action, combined with new "chain" and "jump_chain" columns, allows for policies to be chained together. - Dynamic Routing support (FRR BGP integration for unicast routing) - Add "options:ct-commit-all" to LR, that enables commit of all traffic to DNAT and SNAT zone when LR is stateful. Co-authored-by: Dumitru Ceara <dceara@redhat.com> Signed-off-by: Patryk Diak <pdiak@redhat.com>
|
/lgtm Thanks! |
I assume this list is compiled from the newer build. At least the fix above is not available in the |
Thanks for pointing that out @igsilya! I had incorrectly compiled the list of bug fixes. It should actually be: Sorry, @kyrtapz, can you please update the commit message again? The features section should be correct. Thanks, |
|
/retest |
|
@kyrtapz are you gonna update the commit message again? -> I'm OK if you put that changed info on the PR description instead - so make your PR description also show the correct list of things.. I'm more interested in CI |
|
/test okd-scos-e2e-aws-ovn |
|
Two OKD runs failed in a very similar way: It still might be unrelated to this PR as there was a run without similar failures: All using the same commit. |
|
Some failures are caused by openshift/kubernetes#2382. |
|
/test okd-scos-e2e-aws-ovn |
Failed again with the same failures 😨 Trying a NOOP run here: #2524 (comment) |
|
/test e2e-aws-ovn-fdp-qe |
Same failures seen on a noop PR: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ovn-kubernetes/2524/pull-ci-openshift-ovn-kubernetes-master-okd-scos-e2e-aws-ovn/1953477150501769216 |
The fix merged. |
|
/test e2e-aws-ovn-fdp-qe |
error running /tmp/home/kubectl --server=https://api.ci-op-05mhig6h-96186.origin-ci-int-aws.dev.rhcloud.com:6443 --kubeconfig=/tmp/kubeconfig-2728899560 --namespace=e2e-test-networking-adminnetworkpolicy-2tnbf exec test-pod-73454-0 -- /bin/sh -x -c curl -I --connect-timeout 5 -s 10.0.109.68 10.0.83.191:30003:\nCommand stdout:\n\nstderr:\n+ curl -I --connect-timeout 5 -s 10.0.109.68 10.0.83.191:30003\ncommand terminated with exit code 28\n\nerror:\nexit status 28" Will create a OCPQE ticket to find out which test does not clean up. |
|
/label qe-approved |
|
|
/retest |
1 similar comment
|
/retest |
|
ci/prow/e2e-aws-ovn-hypershift-conformance-techpreview - This is failing on other PRs for the same reason, unlikely related to the OVN bump. |
|
/test e2e-azure-ovn |
|
/test qe-perfscale-aws-ovn-small-udn-density-churn-l3 |
|
qe-perfscale-aws-ovn-small-udn-density-churn-l3 is failing due to a know issue: https://issues.redhat.com/browse/OCPBUGS-59738 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
CI looking good. We are confident that nothing to the best of our knowledge is broken here. But anyways we will have 1.5 sprints of soak time for OVN bump in 4.20 before we GA which is good.
This is blocking code from entering 4.19 since downstream merges are blocked. Let's get this in!
azure jobs that are required should hopefully pass over the weekend - the reasons they fail is not related to us!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dceara, kyrtapz, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
/retest-required |
azure-upgrade seems adamant! |
|
/tide refresh |
|
oh no @kyrtapz i think this PR was opened before the most recent ds merge? so we might have a merge pool churn tide tells me its planning to retest 26 jobs :( |
|
@kyrtapz: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override ci/prow/lint |
|
@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/lint DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
c1ecb1a
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ovn-kubernetes-base |
|
[ART PR BUILD NOTIFIER] Distgit: ovn-kubernetes-microshift |
|
[ART PR BUILD NOTIFIER] Distgit: ose-ovn-kubernetes |
Bump OVN to 25.03.0-73.el9fdp for OCP and 25.03.1-36.el9s for OKD.
Using a different version for OKD as it is currently the only one available.
This is a list of relevant bug fixes and new core OVN features picked up by the bump:
There is a slight error in the commit message as pointed out here. Due to time constraints we've decided to go with it to avoid re-running CI.