Skip to content

Conversation

@danwinship
Copy link

The ServiceCIDR feature, enabled by default in 1.33, does not work in OpenShift. (It requires support from any component that cares if the cluster service CIDRs change.) We're blocking use of it via a VAP (openshift/cluster-network-operator#2605) but will need to also skip the tests for it.

It seems like the test skip stuff has changed since the last time I used it and I'm not sure if this fix is correct...

@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 30, 2025
@openshift-ci-robot
Copy link

@danwinship: This pull request references Jira Issue OCPBUGS-46422, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The ServiceCIDR feature, enabled by default in 1.33, does not work in OpenShift. (It requires support from any component that cares if the cluster service CIDRs change.) We're blocking use of it via a VAP (openshift/cluster-network-operator#2605) but will need to also skip the tests for it.

It seems like the test skip stuff has changed since the last time I used it and I'm not sure if this fix is correct...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

"[Feature:KubeProxyDaemonSetMigration]", // upgrades are run separately
"[Feature:BoundServiceAccountTokenVolume]", // upgrades are run separately
"[Feature:StatefulUpgrade]", // upgrades are run separately
"Service CIDRs", // requires extra support from some components
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bertinatto : Did we get the skip in the right place?

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend the commit message so that it contains the right prefix: https://github.com/bertinatto/kubernetes/blob/9c2642ea7167e203db9f473422f4f9aa4501a51f/README.openshift.md?plain=1#L50-L60

Other than that, LGTM.
/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2025
@danwinship danwinship force-pushed the skip-servicecidr-tests branch from 1964096 to d75c38b Compare August 6, 2025 05:14
@openshift-ci-robot
Copy link

@danwinship: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@danwinship
Copy link
Author

/retest-required

@bertinatto
Copy link
Member

/remove-label backports/unvalidated-commits
/lgtm

@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Aug 6, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2025
@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3e4371f and 2 for PR HEAD d75c38b in total

@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2025

@danwinship: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-upgrade 1964096 link true /test e2e-gcp-ovn-upgrade
ci/prow/configmap-scale 1964096 link true /test configmap-scale
ci/prow/e2e-openstack-csi-manila 1964096 link false /test e2e-openstack-csi-manila
ci/prow/e2e-aws-disruptive 1964096 link false /test e2e-aws-disruptive
ci/prow/e2e-openstack-csi-cinder 1964096 link false /test e2e-openstack-csi-cinder
ci/prow/e2e-aws-ovn-techpreview d75c38b link false /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-techpreview-serial d75c38b link false /test e2e-aws-ovn-techpreview-serial
ci/prow/e2e-metal-ipi-ovn-ipv6 d75c38b link false /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 00d4655 and 1 for PR HEAD d75c38b in total

@kyrtapz
Copy link

kyrtapz commented Aug 7, 2025

/tide refresh

1 similar comment
@tssurya
Copy link

tssurya commented Aug 7, 2025

/tide refresh

@openshift-merge-bot openshift-merge-bot bot merged commit 24677bb into openshift:master Aug 7, 2025
13 of 26 checks passed
@openshift-ci-robot
Copy link

@danwinship: Jira Issue OCPBUGS-46422: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-46422 has not been moved to the MODIFIED state.

Details

In response to this:

The ServiceCIDR feature, enabled by default in 1.33, does not work in OpenShift. (It requires support from any component that cares if the cluster service CIDRs change.) We're blocking use of it via a VAP (openshift/cluster-network-operator#2605) but will need to also skip the tests for it.

It seems like the test skip stuff has changed since the last time I used it and I'm not sure if this fix is correct...

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.20.0-202508072056.p0.g24677bb.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.20.0-202508072056.p0.g24677bb.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.20.0-202508072056.p0.g24677bb.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.20.0-202508072056.p0.g24677bb.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.20.0-0.nightly-2025-11-22-184222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants