-
Notifications
You must be signed in to change notification settings - Fork 128
OCPBUGS-46422: Disable ServiceCIDR tests #2382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-46422: Disable ServiceCIDR tests #2382
Conversation
|
@danwinship: This pull request references Jira Issue OCPBUGS-46422, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@danwinship: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
| "[Feature:KubeProxyDaemonSetMigration]", // upgrades are run separately | ||
| "[Feature:BoundServiceAccountTokenVolume]", // upgrades are run separately | ||
| "[Feature:StatefulUpgrade]", // upgrades are run separately | ||
| "Service CIDRs", // requires extra support from some components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bertinatto : Did we get the skip in the right place?
bertinatto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please amend the commit message so that it contains the right prefix: https://github.com/bertinatto/kubernetes/blob/9c2642ea7167e203db9f473422f4f9aa4501a51f/README.openshift.md?plain=1#L50-L60
Other than that, LGTM.
/approve
1964096 to
d75c38b
Compare
|
@danwinship: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/retest-required |
|
/remove-label backports/unvalidated-commits |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@danwinship: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/tide refresh |
1 similar comment
|
/tide refresh |
24677bb
into
openshift:master
|
@danwinship: Jira Issue OCPBUGS-46422: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-46422 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-pod |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-hyperkube |
|
[ART PR BUILD NOTIFIER] Distgit: kube-proxy |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-kube-apiserver-artifacts |
|
Fix included in accepted release 4.20.0-0.nightly-2025-11-22-184222 |
The ServiceCIDR feature, enabled by default in 1.33, does not work in OpenShift. (It requires support from any component that cares if the cluster service CIDRs change.) We're blocking use of it via a VAP (openshift/cluster-network-operator#2605) but will need to also skip the tests for it.
It seems like the test skip stuff has changed since the last time I used it and I'm not sure if this fix is correct...