Skip to content

Openshift provider for virt and localnet #2641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qinqon wants to merge 19 commits into from
Closed

Openshift provider for virt and localnet #2641

qinqon wants to merge 19 commits into from

Conversation

@qinqon
Copy link
Contributor

@qinqon qinqon commented Jun 18, 2025 •
edited
Loading

📑 Description

Depends on:

Last two commits

Fixes #

Additional Information for reviewers

✅ Checks

  • My code requires changes to the documentation
  • if so, I have updated the documentation as required
  • My code requires tests
  • if so, I have added and/or updated the tests as required
  • All the tests have passed in the CI

How to verify it

@openshift-ci openshift-ci bot requested review from JacobTanenbaum and trozet June 18, 2025 11:18
@qinqon qinqon force-pushed the openshift-provider branch 9 times, most recently from fd97cf4 to b4a69dd Compare June 25, 2025 10:21
@qinqon qinqon force-pushed the openshift-provider branch 2 times, most recently from edc86b4 to 21fdc78 Compare June 26, 2025 11:38
qinqon added 11 commits June 26, 2025 13:47
@qinqon
kv, e2e: Download virtctl at tests
d8b9f5d 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon
kv, e2e: ensure there is no dots at podtest name
766344f 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon
kv, e2e: Don't create external container if not needed
40c0d3f 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon
e2e: Remove harcoded breth0
5e3ca98 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon
e2e, kv: Increase network status timeout
555366d 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon
e2e: Use ovnk allocator and reserve IPs
0e1fd28 
This change replace the customa llocator with the ovnk allocator and
also reserver the cluster IPs so test can just ask for another IP
without the problem of cluster ip collision.

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon
e2e, kv: Use bgpnet for external container network
fe57946 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon
e2e: Move underlay setup to providers
b105a3d 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon
e2e: Move http servers to external container
68d3a84 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon
kv, e2e: Use PrimaryNetwork()
3f6ff94 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon
kv, e2e: use setsid for background commands
25fed34 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon qinqon force-pushed the openshift-provider branch 2 times, most recently from fc073fb to 8177996 Compare June 26, 2025 11:58
@qinqon qinqon changed the title Openshift provider Openshift provider for virt and localnet Jun 26, 2025
@qinqon
Copy link
Contributor Author

qinqon commented Jun 26, 2025

/testwith openshift/origin#29546

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qinqon
Once this PR has been reviewed and has the lgtm label, please assign abhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qinqon
Copy link
Contributor Author

qinqon commented Jun 26, 2025

/test e2e-metal-ipi-ovn-bgp-virt-dualstack

@qinqon
Copy link
Contributor Author

qinqon commented Jun 26, 2025

/payload-job-with-prs periodic-ci-openshift-ovn-kubernetes-release-4.20-periodics-e2e-metal-ipi-ovn-bgp-virt-dualstack openshift/origin#29940

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2025

@qinqon: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-ovn-kubernetes-release-4.20-periodics-e2e-metal-ipi-ovn-bgp-virt-dualstack

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1ef33600-528c-11f0-9d98-853bd438ed96-0

@qinqon
Copy link
Contributor Author

qinqon commented Jun 27, 2025

/payload-job-with-prs periodic-ci-openshift-ovn-kubernetes-release-4.20-periodics-e2e-metal-ipi-ovn-bgp-virt-dualstack openshift/origin#29940

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2025

@qinqon: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-ovn-kubernetes-release-4.20-periodics-e2e-metal-ipi-ovn-bgp-virt-dualstack

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ebf02b50-532b-11f0-8d47-06c21b7c83f1-0

@qinqon qinqon force-pushed the openshift-provider branch 3 times, most recently from 9de2d54 to bdb43c3 Compare July 3, 2025 07:43
martinkennelly and others added 8 commits July 3, 2025 10:55
@martinkennelly @qinqon
<drop> use app instead of name when selecting ovn-k pods
675d592 
'name' isn't used downstream where as 'app' is.

Signed-off-by: Martin Kennelly <mkennell@redhat.com>
@martinkennelly @qinqon
<carry> E2Es: ensure a set of OK features are enabled by default
8bf0346 
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
@martinkennelly @qinqon
<drop> change UDN networks to relatively rare IP ranges
4e1657d 
so as not to conflict with the default network subnet.
128.x.x.x is used intensively.

Signed-off-by: Martin Kennelly <mkennell@redhat.com>
@martinkennelly @qinqon
Add labels to filter e2e tests
9eb98db 
Signed-off-by: Martin Kennelly <mkennell@redhat.com>
@martinkennelly @qinqon
<carry> Add o/test-exts
3e73bdd 
Enabling only NetSeg tests.

Signed-off-by: Martin Kennelly <mkennell@redhat.com>
@qinqon
openshift-hack, vendor: reference back the repo
936b794 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon
e2e, infraprovider: Add openshift provider using kcli
d7b2c1f 
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon
kv, e2e: Add virt test to origin ext
e146184 
openshift-hack: Filter by ginkgo label too

Signed-off-by: Enrique Llorente <ellorent@redhat.com>
@qinqon qinqon force-pushed the openshift-provider branch from bdb43c3 to e146184 Compare July 3, 2025 08:07
@ricky-rav ricky-rav mentioned this pull request Jul 11, 2025
Merged
6 tasks
@martinkennelly martinkennelly mentioned this pull request Sep 2, 2025
Closed
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 2, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 2, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 2, 2025
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Oct 2, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2025

@qinqon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-bgp-virt-dualstack 8177996 link false /test e2e-metal-ipi-ovn-bgp-virt-dualstack
ci/prow/4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade e146184 link true /test 4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-hypershift e146184 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-ovn-hypershift-kubevirt e146184 link false /test e2e-aws-ovn-hypershift-kubevirt
ci/prow/e2e-aws-ovn-hypershift-conformance-techpreview e146184 link false /test e2e-aws-ovn-hypershift-conformance-techpreview
ci/prow/okd-scos-e2e-aws-ovn e146184 link false /test okd-scos-e2e-aws-ovn
ci/prow/4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade e146184 link true /test 4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack e146184 link true /test e2e-metal-ipi-ovn-dualstack
ci/prow/security e146184 link false /test security
ci/prow/e2e-aws-ovn-techpreview e146184 link false /test e2e-aws-ovn-techpreview
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp e146184 link true /test e2e-metal-ipi-ovn-dualstack-bgp
ci/prow/4.21-upgrade-from-stable-4.20-images e146184 link true /test 4.21-upgrade-from-stable-4.20-images
ci/prow/4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade e146184 link true /test 4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade
ci/prow/4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade e146184 link true /test 4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 9, 2025

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 9, 2025
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 9, 2025

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Dec 9, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2025

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

anuragthehatter added a commit to anuragthehatter/ovn-kubernetes that referenced this pull request Jan 13, 2026
@anuragthehatter
Add OpenShift provider for e2e tests
94c5de1 
Cherry-picked OpenShift provider implementation from PR ovn-kubernetes#2641.
This adds the infrastructure provider for running e2e tests on
OpenShift clusters using kcli for machine management.

Includes:
- OpenShift provider implementation with machine, network, and SSH management
- Configuration for baremetal deployments
- NMState and OVS utilities for OpenShift

Note: Integration hooks to register this provider may need to be
added separately based on deployment requirements.

Source: openshift/ovn-kubernetes#2641
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@trozet trozet Awaiting requested review from trozet

Assignees

No one assigned

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qinqon @openshift-bot @openshift-merge-robot @martinkennelly