CORENET-6170: Add OCP tests extension#2461
CORENET-6170: Add OCP tests extension#2461openshift-merge-bot[bot] merged 7 commits intoopenshift:masterfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/hold
|
@martinkennelly: GitHub didn't allow me to request PR reviews from the following users: martinkennelly. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Enable in origin PR: openshift/origin#29546 |
|
/retest |
|
/test images |
|
@martinkennelly: This PR was included in a payload test run from openshift/origin#29546
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7ed92a30-edf0-11ef-9c0e-969e451224c9-0 |
|
@martinkennelly: This PR was included in a payload test run from openshift/origin#29546 |
|
@martinkennelly: This PR was included in a payload test run from openshift/origin#29546
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f56add10-edf0-11ef-9bb1-df918fe19020-0 |
martinkennelly
force-pushed
the
init-ocp-extensions-net-seg
branch
from
f7d3e2a to
5814df7
Compare
|
@martinkennelly: This PR was included in a payload test run from openshift/origin#29546
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea0be960-edfe-11ef-80e0-5a872e60b37d-0 |
martinkennelly
force-pushed
the
init-ocp-extensions-net-seg
branch
7 times, most recently
from
183536a to
d2fb4a5
Compare
|
@martinkennelly: This PR was included in a payload test run from openshift/origin#29546
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7f7faaa0-ef75-11ef-96a2-28660f14b785-0 |
martinkennelly
force-pushed
the
init-ocp-extensions-net-seg
branch
from
d2fb4a5 to
9943987
Compare
openshift-merge-robot
added
the
needs-rebase
martinkennelly
force-pushed
the
init-ocp-extensions-net-seg
branch
2 times, most recently
from
63ccc62 to
effa544
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest |
martinkennelly
force-pushed
the
init-ocp-extensions-net-seg
branch
from
effa544 to
4497133
Compare
stbenjam
left a comment
stbenjam
left a comment
There was a problem hiding this comment.
This is awesome!!!! A few things I noticed
There was a problem hiding this comment.
Test names don't match up which cause some problems -- we won't be able to compare across releases for regressions.
Because these tests also exist in origin, origin won't know to override the internal test with the external one.
I see it two options:
- Keep the new names, but try to create a rename mapping file for ci-test-mapping to link up the renames. And remove the existing tests in origin.
- Make the names match somehow
origin:
[sig-network][OCPFeatureGate:NetworkSegmentation][Feature:UserDefinedPrimaryNetworks] when using openshift ovn-kubernetes ClusterUserDefinedNetwork CRD Controller pod connected to ClusterUserDefinedNetwork CR & managed NADs cannot be deleted when being used [Suite:openshift/conformance/parallel]
ovnk-tests-ext:
[ovn-kubernetes][Feature:NetworkSegmentation] ClusterUserDefinedNetwork CRD Controller pod connected to ClusterUserDefinedNetwork CR & managed NADs cannot be deleted when being used [Suite:openshift/conformance/parallel]
There was a problem hiding this comment.
Keep the new names, but try to create a rename mapping file for ci-test-mapping to link up the renames. And remove the existing tests in origin.
Yea, I went with renaming in-order to be consistent. Thats still WIP upstream but i cherry-picked it here for test.
There was a problem hiding this comment.
Working on renaming PR tomorrow.
| ovnTestsExtension.AddSuite(e.Suite{ | ||
| Name: "ovn-kubernetes/conformance/serial", | ||
| Parents: []string{ | ||
| "openshift/conformance/serial", | ||
| }, | ||
| Qualifiers: []string{`!labels.exists(l, l == "Serial") && labels.exists(l, l == "Conformance")`}, | ||
| }) |
There was a problem hiding this comment.
The suites code isn't implemented yet (origin will select tests based on [Suite:xyz] currently) -- but you'll want to include parallel here for when it does. I see some parallel tests in list tests, but no suites config for it here.
There was a problem hiding this comment.
True - oops. I mixed it up. I meant to be optimised and try put all tests as parallel and if we see problems, switch to serial. Updated. PTAL.
martinkennelly
force-pushed
the
init-ocp-extensions-net-seg
branch
from
4497133 to
c85defb
Compare
|
@martinkennelly: This PR was included in a payload test run from openshift/origin#29546
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6d7781c0-f434-11ef-8801-1e469e8c62a6-0 |
martinkennelly
force-pushed
the
init-ocp-extensions-net-seg
branch
from
c85defb to
19627b7
Compare
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a583f630-f31f-11f0-89cd-68982a37826c-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade openshift/origin#29546 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade openshift/origin#29546 |
|
/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aks openshift/origin#29546 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e104cf90-f31f-11f0-86fa-cc8c0500f5a7-0 |
|
/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-ovn openshift/origin#29546 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e2179f20-f31f-11f0-9ae4-a69226954c62-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-aws-upgrade-ovn-single-node openshift/origin#29546 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e34c4e90-f31f-11f0-8c56-a1c4efa261d7-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-upgrade-fips openshift/origin#29546 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e4960ca0-f31f-11f0-8a43-6527a2349b17-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade openshift/origin#29546 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e6177c80-f31f-11f0-8d3d-50ebf14af52b-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-rt-upgrade openshift/origin#29546 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e72039f0-f31f-11f0-9708-1f3b3c99d6a1-0 |
|
/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-ovn-conformance openshift/origin#29546 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e7eed490-f31f-11f0-9345-4ac7e02c626f-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview openshift/origin#29546 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e9685530-f31f-11f0-96e3-1c8de3a26c55-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-bm openshift/origin#29546 |
|
/payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.21-e2e-metal-ipi-ovn-ipv6 openshift/origin#29546 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ea80ca10-f31f-11f0-8c0b-0d3aa838b264-0 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/eb310740-f31f-11f0-9e54-82a3149c994d-0 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ecb5ab70-f31f-11f0-9143-92623cd72249-0 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ed9228c0-f31f-11f0-9118-f9961c45fcf6-0 |
|
/verified in ci |
|
@pperiyasamy: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by ci |
|
@pperiyasamy: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold cancel |
12 participants
/hold
/cc