Skip to content

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #2459

/assign jluhrsen

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-49598 has been cloned as Jira Issue OCPBUGS-51143. Will retitle bug to link to clone.

Jira Issue OCPBUGS-49393 has been cloned as Jira Issue OCPBUGS-51144. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-51143, OCPBUGS-51144: [DownstreamMerge] 13 feb 2025

Details

In response to this:

This is an automated cherry-pick of #2459

/assign jluhrsen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-49598, OCPBUGS-49393: [DownstreamMerge] 13 feb 2025 [release-4.18] OCPBUGS-51143, OCPBUGS-51144: [DownstreamMerge] 13 feb 2025 Feb 21, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 21, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-51143, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-51144, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #2459

/assign jluhrsen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jluhrsen
Copy link
Contributor

/hold
not trying to get this in right now before 4.18 GA. just getting a head start on the sync

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2025
@jluhrsen
Copy link
Contributor

/retitle [release-4.18] OCPBUGS-48710: DownStream Merge Sync from 4.19 [02-13-2025]

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-51143, OCPBUGS-51144: [DownstreamMerge] 13 feb 2025 [release-4.18] OCPBUGS-48710: DownStream Merge Sync from 4.19 [02-13-2025] Feb 21, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 21, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-48710, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-48709 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-48709 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #2459

/assign jluhrsen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

RamLavi and others added 11 commits February 24, 2025 10:20
The document is refactored to meet the ovn-org feature template [0].

[0]
https://github.com/ovn-org/ovn-kubernetes/blob/master/docs/features/template.md

Signed-off-by: Ram Lavi <ralavi@redhat.com>
Signed-off-by: Ram Lavi <ralavi@redhat.com>
Signed-off-by: arkadeepsen <arsen@redhat.com>
Fixes a null pointer exception when network policy port has no protocol.
If the protocol is missing in the network policy port definition, it
should be assumed to be TCP.

Signed-off-by: Tim Rozet <trozet@redhat.com>
Add a few more missing `Expect(err).NotTo(HaveOccurred())` to nftables
checks so they'll actually fail if the rules are wrong.

Signed-off-by: Dan Winship <danwinship@redhat.com>
One of UDN local gateway masquerade rules was using an IP/length (eg.
169.254.0.2/29) rather than subnet/length (169.254.0.0/29). This is
ambiguous and we shouldn't depend on iptables interpreting it the way
we wanted.

Also, the corresponding unit test ended up being sort of silly because
it wasn't overriding the masquerade subnet to be "UDN-sized", so the
rules it output failed to actually distinguish the UDN and non-UDN
parts of the masquerade subnet. Fix that too.

Signed-off-by: Dan Winship <danwinship@redhat.com>
Signed-off-by: Joel Takvorian <jtakvori@redhat.com>
We want to use "k8s.io/api/core/v1.ObjectReference" for event reporting.
At the same time "k8s.io/kubernetes/pkg/apis/core.ObjectReference"
exists.
The fun part is that in default_node_network_controller.go we import
  kapi "k8s.io/api/core/v1"
and in udn_isolation.go
  v1 "k8s.io/api/core/v1"
  kapi "k8s.io/kubernetes/pkg/apis/core"

so when the tested code was moved to another file, it started using the
wrong type.

Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
I am trying to debug an issue where this error occurs
and I dont easily know what pod UIDs that were compared.

Signed-off-by: Martin Kennelly <mkennell@redhat.com>
…t restarted.

Signed-off-by: Dan Winship <danwinship@redhat.com>
Signed-off-by: Dan Winship <danwinship@redhat.com>
Co-authored-by: Martin Kennelly <mkennell@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2025
@jluhrsen
Copy link
Contributor

4.18 GA'ed

/hold cancel

@trozet , I feel like we should always get payload jobs on branches that have z release possibility though. no?

@npinaeva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: npinaeva, openshift-cherrypick-robot, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jluhrsen
Copy link
Contributor

4.18 GA'ed
/hold cancel

@trozet , I feel like we should always get payload jobs on branches that have z release possibility though. no?

the payload jobs were not super pretty, but none of the failures seemed like it would be related to ovnk. but let me re-run the failed ones one more time just to be safe
/hold

/payload-job periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
/payload-job periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn
/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-upgrade-ovn-single-node
/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview
/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2025

@jluhrsen: trigger 6 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/23fc9360-f532-11ef-91df-4a75a7b8780c-0

@asood-rh
Copy link
Contributor

asood-rh commented Mar 3, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 3, 2025
@jluhrsen
Copy link
Contributor

jluhrsen commented Mar 3, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 799f961 into openshift:release-4.18 Mar 3, 2025
39 of 42 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-48710: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-48710 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #2459

/assign jluhrsen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-base
This PR has been included in build ose-ovn-kubernetes-base-container-v4.18.0-202503031833.p0.g799f961.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ovn-kubernetes-microshift
This PR has been included in build ovn-kubernetes-microshift-container-v4.18.0-202503031833.p0.g799f961.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-ovn-kubernetes
This PR has been included in build ose-ovn-kubernetes-container-v4.18.0-202503031833.p0.g799f961.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.18.0-0.nightly-2025-06-26-034047

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.18.0-0.nightly-2025-10-23-005402

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.18.0-0.nightly-2025-12-24-222251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.