-
Notifications
You must be signed in to change notification settings - Fork 173
[release-4.18] OCPBUGS-48710: DownStream Merge Sync from 4.19 [02-13-2025] #2470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.18] OCPBUGS-48710: DownStream Merge Sync from 4.19 [02-13-2025] #2470
Conversation
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-49598 has been cloned as Jira Issue OCPBUGS-51143. Will retitle bug to link to clone. Jira Issue OCPBUGS-49393 has been cloned as Jira Issue OCPBUGS-51144. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-51143, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-51144, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
|
/retitle [release-4.18] OCPBUGS-48710: DownStream Merge Sync from 4.19 [02-13-2025] |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-48710, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The document is refactored to meet the ovn-org feature template [0]. [0] https://github.com/ovn-org/ovn-kubernetes/blob/master/docs/features/template.md Signed-off-by: Ram Lavi <ralavi@redhat.com>
Signed-off-by: Ram Lavi <ralavi@redhat.com>
Signed-off-by: arkadeepsen <arsen@redhat.com>
Fixes a null pointer exception when network policy port has no protocol. If the protocol is missing in the network policy port definition, it should be assumed to be TCP. Signed-off-by: Tim Rozet <trozet@redhat.com>
Add a few more missing `Expect(err).NotTo(HaveOccurred())` to nftables checks so they'll actually fail if the rules are wrong. Signed-off-by: Dan Winship <danwinship@redhat.com>
One of UDN local gateway masquerade rules was using an IP/length (eg. 169.254.0.2/29) rather than subnet/length (169.254.0.0/29). This is ambiguous and we shouldn't depend on iptables interpreting it the way we wanted. Also, the corresponding unit test ended up being sort of silly because it wasn't overriding the masquerade subnet to be "UDN-sized", so the rules it output failed to actually distinguish the UDN and non-UDN parts of the masquerade subnet. Fix that too. Signed-off-by: Dan Winship <danwinship@redhat.com>
Signed-off-by: Joel Takvorian <jtakvori@redhat.com>
We want to use "k8s.io/api/core/v1.ObjectReference" for event reporting. At the same time "k8s.io/kubernetes/pkg/apis/core.ObjectReference" exists. The fun part is that in default_node_network_controller.go we import kapi "k8s.io/api/core/v1" and in udn_isolation.go v1 "k8s.io/api/core/v1" kapi "k8s.io/kubernetes/pkg/apis/core" so when the tested code was moved to another file, it started using the wrong type. Signed-off-by: Nadia Pinaeva <npinaeva@redhat.com>
I am trying to debug an issue where this error occurs and I dont easily know what pod UIDs that were compared. Signed-off-by: Martin Kennelly <mkennell@redhat.com>
…t restarted. Signed-off-by: Dan Winship <danwinship@redhat.com>
Signed-off-by: Dan Winship <danwinship@redhat.com> Co-authored-by: Martin Kennelly <mkennell@redhat.com>
@trozet , I feel like we should always get payload jobs on branches that have z release possibility though. no? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: npinaeva, openshift-cherrypick-robot, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the payload jobs were not super pretty, but none of the failures seemed like it would be related to ovnk. but let me re-run the failed ones one more time just to be safe /payload-job periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade |
|
@jluhrsen: trigger 6 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/23fc9360-f532-11ef-91df-4a75a7b8780c-0 |
|
/label cherry-pick-approved |
|
/hold cancel
|
799f961
into
openshift:release-4.18
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-48710: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-48710 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ovn-kubernetes-base |
|
[ART PR BUILD NOTIFIER] Distgit: ovn-kubernetes-microshift |
|
[ART PR BUILD NOTIFIER] Distgit: ose-ovn-kubernetes |
|
Fix included in accepted release 4.18.0-0.nightly-2025-06-26-034047 |
|
Fix included in accepted release 4.18.0-0.nightly-2025-10-23-005402 |
|
Fix included in accepted release 4.18.0-0.nightly-2025-12-24-222251 |
This is an automated cherry-pick of #2459
/assign jluhrsen